Add support for open-iscsi transports. #16877

anish · 2015-11-05T21:31:25Z

This enables use of software or hardware transports viz. be2iscsi,
bnx2i, cxgb3i, cxgb4i, qla4xx, iser and ocs. The default transport
(tcp) happens to be called "default".

Use of non-default transports changes the disk path to the following format:
/dev/disk/by-path/pci-<pci_id>-ip--iscsi--lun-<lun_id>

k8s-bot · 2015-11-05T21:32:11Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot · 2015-11-05T21:33:11Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-github-robot · 2015-11-05T21:39:45Z

Labelling this PR as size/M

anish · 2015-11-05T22:02:31Z

Can anyone give me pointers on this ? Build fails with
./pkg/api/v1/types.generated.go is out of date. Please run hack/update-codecgen.sh

actually running that generates a very big changeset, not sure if I'm supposed to be doing that add adding it to the commit. There seems to be a Issue #16128 open for this as well

k8s-github-robot · 2015-11-06T03:39:46Z

Labelling this PR as size/XXL

pmorie · 2015-11-06T15:21:49Z

@k8s-bot test this

pmorie · 2015-11-06T15:26:55Z

@anish running update-codecgen.sh might generate a large changeset for now. You should run:

$ hack/update-all.sh && hack/verify-all.sh

k8s-bot · 2015-11-06T15:49:15Z

GCE e2e test build/test passed for commit c23041ae932960fd6a9d35ca00923f4d9c5e27fe.

anish · 2015-11-06T21:51:48Z

@pmorie that's what I originally went for, but travis-ci insisted on running update-codecgen.sh, you can see the original log at https://s3.amazonaws.com/archive.travis-ci.org/jobs/89531094/log.txt

anish · 2015-11-06T21:52:15Z

Also probably need @rootfs to chime in since it's iscsi

pmorie · 2015-11-07T06:28:05Z

@kubernetes/rh-storage

rootfs · 2015-11-07T14:53:43Z

pkg/volume/iscsi/iscsi_util.go

+	if b.iface == "default" {
+		devicePath = strings.Join([]string{"/dev/disk/by-path/ip", b.portal, "iscsi", b.iqn, "lun", b.lun}, "-")
+	} else {
+		devicePath = strings.Join([]string{"/dev/disk/by-path/pci", "*", "ip", b.portal, "iscsi", b.iqn, "lun", b.lun}, "-")


I don't have the setup. Any reference in udev I can see this device path?

I think this is what you want.

You can take a look at the openstack changes that do the same here and here

k8s-bot · 2015-12-07T04:29:23Z

GCE e2e build/test failed for commit c963b3b35d47ced2589fb3227ca35b4aa0a88db2.

pmorie · 2015-12-07T18:54:43Z

@k8s-bot test this

k8s-bot · 2015-12-07T20:03:41Z

GCE e2e build/test failed for commit c963b3b35d47ced2589fb3227ca35b4aa0a88db2.

pmorie · 2015-12-07T21:27:43Z

@k8s-bot test this

anish · 2015-12-07T22:16:06Z

I ran this locally, none of the stuff causing errors seem to be completely unrelated to any of my code, error logs here if anyone would care to take a look :

https://gist.github.com/anish/2454dab407c4e9ea9418

Only changes on my side have been a rebase requiring some changes to the api html files.

k8s-bot · 2015-12-07T22:24:32Z

GCE e2e test build/test passed for commit c963b3b35d47ced2589fb3227ca35b4aa0a88db2.

pmorie · 2015-12-07T22:25:54Z

@k8s-bot unit test this

This enables use of software or hardware transports viz. be2iscsi, bnx2i, cxgb3i, cxgb4i, qla4xx, iser and ocs. The default transport (tcp) happens to be called "default". Use of non-default transports changes the disk path to the following format: /dev/disk/by-path/pci-<pci_id>-ip-<portal>-iscsi-<iqn>-lun-<lun_id>

k8s-github-robot · 2015-12-09T01:36:03Z

PR changed after LGTM, removing LGTM.

k8s-bot · 2015-12-09T01:56:21Z

GCE e2e test build/test passed for commit 6e46fa1.

anish · 2015-12-09T02:35:55Z

Will check back later, but the failing test passes locally :

[anish@kerb kubernetes]$ git branch
* iscsi_iface
  master
[anish@kerb kubernetes]$ hack/test-go.sh pkg/api
Running tests for APIVersion: v1,extensions/v1beta1,metrics/v1alpha1 with etcdPrefix: registry
+++ [1208 18:33:20] Running tests without code coverage
ok      k8s.io/kubernetes/pkg/api       1.143s
Running tests for APIVersion: v1,extensions/v1beta1,metrics/v1alpha1 with etcdPrefix: kubernetes.io/registry
+++ [1208 18:33:29] Running tests without code coverage
ok      k8s.io/kubernetes/pkg/api       1.335s

pmorie · 2015-12-09T14:51:08Z

@k8s-bot unit test this

k8s-github-robot · 2015-12-09T17:27:17Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2015-12-09T18:01:52Z

GCE e2e test build/test passed for commit 6e46fa1.

k8s-github-robot · 2015-12-09T18:30:37Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2015-12-09T19:05:02Z

GCE e2e test build/test passed for commit 6e46fa1.

k8s-github-robot · 2015-12-09T19:16:55Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2015-12-09T19:52:21Z

GCE e2e test build/test passed for commit 6e46fa1.

k8s-github-robot · 2015-12-09T19:52:37Z

Automatic merge from submit-queue

Auto commit by PR queue bot

googlebot added the cla: yes label Nov 5, 2015

anish force-pushed the iscsi_iface branch from bd663a1 to 8f4b189 Compare November 5, 2015 21:38

k8s-github-robot assigned thockin Nov 5, 2015

k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2015

anish force-pushed the iscsi_iface branch from 8f4b189 to 683237a Compare November 6, 2015 03:33

k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 6, 2015

anish force-pushed the iscsi_iface branch 2 times, most recently from 886f58f to c5b32d7 Compare November 6, 2015 04:05

mikedanese mentioned this pull request Nov 6, 2015

TEST: update codecgen #16559

Closed

anish force-pushed the iscsi_iface branch 3 times, most recently from 3a0ae73 to c23041a Compare November 6, 2015 10:48

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2015

rootfs reviewed Nov 7, 2015
View reviewed changes

pmorie added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2015

anish force-pushed the iscsi_iface branch from c963b3b to 6e46fa1 Compare December 9, 2015 01:29

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2015

pmorie closed this Dec 9, 2015

pmorie reopened this Dec 9, 2015

pmorie added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2015

k8s-github-robot pushed a commit that referenced this pull request Dec 9, 2015

Merge pull request #16877 from anish/iscsi_iface

5f7019a

Auto commit by PR queue bot

k8s-github-robot merged commit 5f7019a into kubernetes:master Dec 9, 2015

anish deleted the iscsi_iface branch December 10, 2015 09:25

anish restored the iscsi_iface branch December 10, 2015 09:25

mleklund mentioned this pull request Jun 16, 2017

Add multipath iscsi support for multiple initiator logins #46041

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for open-iscsi transports. #16877

Add support for open-iscsi transports. #16877

anish commented Nov 5, 2015

k8s-bot commented Nov 5, 2015

k8s-bot commented Nov 5, 2015

k8s-github-robot commented Nov 5, 2015

anish commented Nov 5, 2015

k8s-github-robot commented Nov 6, 2015

pmorie commented Nov 6, 2015

pmorie commented Nov 6, 2015

k8s-bot commented Nov 6, 2015

anish commented Nov 6, 2015

anish commented Nov 6, 2015

pmorie commented Nov 7, 2015

rootfs Nov 7, 2015

anish Nov 7, 2015

rootfs Nov 9, 2015

k8s-bot commented Dec 7, 2015

pmorie commented Dec 7, 2015

k8s-bot commented Dec 7, 2015

pmorie commented Dec 7, 2015

anish commented Dec 7, 2015

k8s-bot commented Dec 7, 2015

pmorie commented Dec 7, 2015

k8s-github-robot commented Dec 9, 2015

k8s-bot commented Dec 9, 2015

anish commented Dec 9, 2015

pmorie commented Dec 9, 2015

k8s-github-robot commented Dec 9, 2015

k8s-bot commented Dec 9, 2015

k8s-github-robot commented Dec 9, 2015

k8s-bot commented Dec 9, 2015

k8s-github-robot commented Dec 9, 2015

k8s-bot commented Dec 9, 2015

k8s-github-robot commented Dec 9, 2015

Add support for open-iscsi transports. #16877

Add support for open-iscsi transports. #16877

Conversation

anish commented Nov 5, 2015

k8s-bot commented Nov 5, 2015

k8s-bot commented Nov 5, 2015

k8s-github-robot commented Nov 5, 2015

anish commented Nov 5, 2015

k8s-github-robot commented Nov 6, 2015

pmorie commented Nov 6, 2015

pmorie commented Nov 6, 2015

k8s-bot commented Nov 6, 2015

anish commented Nov 6, 2015

anish commented Nov 6, 2015

pmorie commented Nov 7, 2015

rootfs Nov 7, 2015

Choose a reason for hiding this comment

anish Nov 7, 2015

Choose a reason for hiding this comment

rootfs Nov 9, 2015

Choose a reason for hiding this comment

k8s-bot commented Dec 7, 2015

pmorie commented Dec 7, 2015

k8s-bot commented Dec 7, 2015

pmorie commented Dec 7, 2015

anish commented Dec 7, 2015

k8s-bot commented Dec 7, 2015

pmorie commented Dec 7, 2015

k8s-github-robot commented Dec 9, 2015

k8s-bot commented Dec 9, 2015

anish commented Dec 9, 2015

pmorie commented Dec 9, 2015

k8s-github-robot commented Dec 9, 2015

k8s-bot commented Dec 9, 2015

k8s-github-robot commented Dec 9, 2015

k8s-bot commented Dec 9, 2015

k8s-github-robot commented Dec 9, 2015

k8s-bot commented Dec 9, 2015

k8s-github-robot commented Dec 9, 2015