Add verification to code gen #16810
Add verification to code gen #16810
Conversation
k8s-github-robot
added
the
size/L
|
Labelling this PR as size/L |
|
GCE e2e build/test failed for commit 0a65b1627adcb5aab5bb0f5f8a49854f1ddd2df7. |
| // StableCommandLine returns the command that will invoke this generator; it | ||
| // will be stable when the generator is run in verify mode. (For use if you | ||
| // want to include the command line as instructions in the generated output | ||
| // without making --verify-only fail.) |
There was a problem hiding this comment.
I'm afraid I'm completely lost in this comment :( [to be honest I don't understand it]
|
Sorry for long response. Generally LGTM - just few very minor comments. |
|
@lavalamp - it seems that you didn't update the PR here... |
|
Yeah sorry, I got bogged down by the bank scripts not working.
|
|
@lavalamp - friendly ping |
k8s-github-robot
added
the
needs-rebase
|
@lavalamp - what is blocking this PR? |
|
The build scripts. One of my goals for the day is to get this mergable. |
|
OK, fixed & rebased. PTAL |
k8s-github-robot
removed
the
needs-rebase
|
GCE e2e test build/test passed for commit 691db35514e4d380d491ccb5d21901a04b0e2817. |
| @@ -44,6 +46,8 @@ func main() { | |||
| generators.DefaultNameSystem(), | |||
| generators.Packages, | |||
| ); err != nil { | |||
| glog.Fatalf("Error: %v", err) | |||
| glog.Errorf("Error: %v", err) | |||
There was a problem hiding this comment.
just curious - why do you change this? What is wrong with glog.Fatalf?
There was a problem hiding this comment.
I don't actually recall changing this-- maybe I was paranoid about the exit code?
|
LGTM - (just 2 very minor comment) |
| @@ -0,0 +1,30 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
this is an extra file I'll delete, not sure where it came from
|
I have a rebase error I need to fix... |
|
OK hopefully fixed for real now. |
|
GCE e2e test build/test passed for commit 56cae7c. |
|
Applying @wojtek-t's LGTM |
lavalamp
added
the
lgtm
|
Travis continuous integration appears to have missed, closing and re-opening to trigger it |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test failed for commit 56cae7c. |
|
LGTM |
|
@k8s-bot e2e test this please |
|
GCE e2e test build/test passed for commit 56cae7c. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
As we convert things over we can hopefully lose the scripts that do file copying for verification.