Fix beta versioning for build/push_ci_build.sh #16767
Conversation
ikehz
added
area/build-release
area/release-eng
|
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
|
GCE e2e build/test failed for commit 18f5fc373b6b8b728b7ed34e1022dd493695f026. |
|
@ixdy why did these fail? I'm not clear on either failure. |
|
@k8s-bot test this please |
|
@k8s-bot unit test this please |
|
I was trying to set up an additional build machine for the pull Jenkins. It did not go well. |
|
GCE e2e build/test failed for commit 18f5fc373b6b8b728b7ed34e1022dd493695f026. |
|
@k8s-bot test this please |
|
Fixes #16787. |
|
@zmerlynn Can I get a quick review on this? The 1.1 build is failing due to versioning problems, so we should get this in asap. |
|
GCE e2e test build/test passed for commit 18f5fc373b6b8b728b7ed34e1022dd493695f026. |
| @@ -1246,14 +1246,13 @@ function kube::release::gcs::verify_ci_ge() { | |||
| greater=false | |||
| elif [[ "${version_patch}" -gt "${gcs_version_patch}" ]]; then | |||
| : # fall out | |||
| elif [[ "${version_prerelease}" =~ alpha.* && "${gcs_version_prerelease}" == "beta" ]]; then | |||
| elif [[ "${version_prerelease}" < "${gcs_version_prerelease}" ]]; then | |||
There was a problem hiding this comment.
All other comparisons in this file use -lt.
There was a problem hiding this comment.
Correct. This phrase is lexicographically comparing strings, not integers. -lt is for ints, < is for strings.
|
@k8s-bot unit test this |
zmerlynn
added
the
lgtm
|
LGTM |
|
PR changed after LGTM, removing LGTM. |
|
Labelling this PR as size/XL |
k8s-github-robot
added
needs-rebase
|
Labelling this PR as size/S |
k8s-github-robot
added
size/S
|
GCE e2e build/test failed for commit fdab27ffc0b7d8716f31c403f3ff7a6c361c5bf4. |
zmerlynn
added
the
lgtm
|
GCE e2e test build/test passed for commit eaefc11. |
Manual merge to get into release-1.1 sooner: Fix beta versioning for build/push_ci_build.sh
…6767-upstream-release-1.1 Fix beta versioning for build/push_ci_build.sh
…pick-of-#16767-upstream-release-1.1 Fix beta versioning for build/push_ci_build.sh
…pick-of-#16767-upstream-release-1.1 Fix beta versioning for build/push_ci_build.sh
@ixdy This should fix the release-1.1 builder, (once cherrypicked into release-1.1; unfortunately, that means un-freezing release-1.1.)
@quinton-hoole @bgrant0607 FYI.