Fixing missing swagger spec for apis/extensions #16690
Conversation
|
Labelling this PR as size/M |
k8s-github-robot
added
the
size/M
| @@ -672,7 +672,7 @@ func (m *Master) init(c *Config) { | |||
| Versions: expAPIVersions, | |||
| PreferredVersion: unversioned.GroupVersion{GroupVersion: storageVersion, Version: apiutil.GetVersion(storageVersion)}, | |||
| } | |||
| apiserver.AddGroupWebService(m.handlerContainer, c.APIGroupPrefix+"/"+latest.GroupOrDie("extensions").Group+"/", group) | |||
| apiserver.AddGroupWebService(m.handlerContainer, c.APIGroupPrefix+"/"+latest.GroupOrDie("extensions").Group, group) | |||
There was a problem hiding this comment.
@nikhiljindal, this seems unrelated to /swaggerapi/...? This should only affect /apis/extensions/ ?
There was a problem hiding this comment.
/swaggerapi is auto generated.
/swaggerapi/apis/extensions/ was returning ApiDeclaration not found. This change fixes that
There was a problem hiding this comment.
I see. Maybe go-restful requires there's no trailing "/". Could you double check /apis/extensions/ and /apis/extensions still work? Because that's the paths directly affected by this line. Thanks.
There was a problem hiding this comment.
@nikhiljindal, Could you double check /apis/extensions/ and /apis/extensions still work? Because that's the paths directly affected by this line. Thanks.
There was a problem hiding this comment.
Yes Verified that both of them work
|
Why was the "/" there? |
|
@bgrant0607 I dont think that there was a specific reason. |
|
GCE e2e test build/test passed for commit 326d333. |
|
@k8s-bot unit test this please |
|
Can I get an LGTM? |
caesarxuchao
added
the
lgtm
Fixing missing swagger spec for apis/extensions
…#16690-upstream-release-1.1 Automated cherry pick of #16690 upstream release 1.1
…y-pick-of-#16690-upstream-release-1.1 Automated cherry pick of kubernetes#16690 upstream release 1.1
…y-pick-of-#16690-upstream-release-1.1 Automated cherry pick of kubernetes#16690 upstream release 1.1
Fixes #16687
The only difference between /apis/extensions and other paths (such as /apis) was "/" at the end. I tried removing it and that fixed the issue :)
cc @bgrant0607 @caesarxuchao @lavalamp