-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a support for system-z architecture by adding system-z host #16662
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
1 similar comment
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
Labelling this PR as size/XS |
@gajju26 please sign the CLA as requested. Thanks! |
@ixdy I'm working for IBM and covered as part of Google Corporate CLA (my id has been added as graut.ibm@gmail.com). Please let me know if there is any additional info required. |
CLAs look good, thanks! |
Great, thanks for getting the CLA stuff worked out. There are a few other locations which case on the machine type (just searching for It'd probably be worth updating those, too. Thanks! |
@ixdy as per review comment I have changed the following files for to support system-z architecture. |
Labelling this PR as size/S |
lgtm |
@gajju26 can you please squash your two commits into one? |
GCE e2e build/test failed for commit 29803f343aa6882e58c0893d44b051cd84408346. |
@ixdy I have squashed two commits into one. Thanks!!!! |
GCE e2e test build/test passed for commit 37214ee4d14bec78bf5f8155f9a74b625edd6437. |
@gajju26 hmm, I'm not sure what happened, but now there appear to be 4 commits in your pull request, rather than 2 or 1. https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit is a pretty useful guide I just found that explains how to use |
GCE e2e test build/test passed for commit 94093d9. |
@ixdy I have squashed two commits into one. Thanks!!!! |
LGTM, thanks! |
Continuous integration appears to have missed, closing and re-opening to trigger it |
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
GCE e2e build/test failed for commit 94093d9. |
@k8s-bot e2e test this |
GCE e2e test build/test passed for commit 94093d9. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e test build/test passed for commit 94093d9. |
Automatic merge from submit-queue |
Auto commit by PR queue bot
Added a support for system-z architecture by adding system-z host
architecture name as s390x in the switch case.