Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a support for system-z architecture by adding system-z host #16662

Merged
merged 1 commit into from
Dec 1, 2015

Conversation

gajju26
Copy link
Contributor

@gajju26 gajju26 commented Nov 2, 2015

Added a support for system-z architecture by adding system-z host
architecture name as s390x in the switch case.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@k8s-bot
Copy link

k8s-bot commented Nov 2, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Nov 2, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2015
@ixdy
Copy link
Member

ixdy commented Nov 2, 2015

@gajju26 please sign the CLA as requested. Thanks!

@gajju26
Copy link
Contributor Author

gajju26 commented Nov 5, 2015

@ixdy I'm working for IBM and covered as part of Google Corporate CLA (my id has been added as graut.ibm@gmail.com). Please let me know if there is any additional info required.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 5, 2015
@ixdy
Copy link
Member

ixdy commented Nov 5, 2015

Great, thanks for getting the CLA stuff worked out.

There are a few other locations which case on the machine type (just searching for uname -m):
hack/local-up-cluster.sh
cluster/get-kube.sh
cluster/kubectl.sh

It'd probably be worth updating those, too. Thanks!

@gajju26
Copy link
Contributor Author

gajju26 commented Nov 6, 2015

@ixdy as per review comment I have changed the following files for to support system-z architecture.
hack/local-up-cluster.sh
cluster/get-kube.sh
cluster/kubectl.sh

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/S

@ixdy
Copy link
Member

ixdy commented Nov 10, 2015

lgtm
ok to test

@ixdy ixdy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2015
@ixdy
Copy link
Member

ixdy commented Nov 10, 2015

@gajju26 can you please squash your two commits into one?

@ixdy ixdy removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 10, 2015

GCE e2e build/test failed for commit 29803f343aa6882e58c0893d44b051cd84408346.

@gajju26
Copy link
Contributor Author

gajju26 commented Nov 16, 2015

@ixdy I have squashed two commits into one. Thanks!!!!

@k8s-bot
Copy link

k8s-bot commented Nov 16, 2015

GCE e2e test build/test passed for commit 37214ee4d14bec78bf5f8155f9a74b625edd6437.

@ixdy
Copy link
Member

ixdy commented Nov 16, 2015

@gajju26 hmm, I'm not sure what happened, but now there appear to be 4 commits in your pull request, rather than 2 or 1.

https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit is a pretty useful guide I just found that explains how to use git rebase -i to squash commits.

@k8s-bot
Copy link

k8s-bot commented Nov 26, 2015

GCE e2e test build/test passed for commit 94093d9.

@gajju26
Copy link
Contributor Author

gajju26 commented Nov 30, 2015

@ixdy I have squashed two commits into one. Thanks!!!!

@ixdy
Copy link
Member

ixdy commented Nov 30, 2015

LGTM, thanks!

@ixdy ixdy added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Nov 30, 2015
@k8s-github-robot
Copy link

Continuous integration appears to have missed, closing and re-opening to trigger it

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Nov 30, 2015

GCE e2e build/test failed for commit 94093d9.

@ixdy
Copy link
Member

ixdy commented Nov 30, 2015

@k8s-bot e2e test this

@k8s-bot
Copy link

k8s-bot commented Nov 30, 2015

GCE e2e test build/test passed for commit 94093d9.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Dec 1, 2015

GCE e2e test build/test passed for commit 94093d9.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants