Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect output. #16382

Merged
merged 1 commit into from
Oct 29, 2015

Conversation

aveshagarwal
Copy link
Member

No description provided.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 27, 2015
@ixdy
Copy link
Member

ixdy commented Oct 27, 2015

lgtm

@ixdy ixdy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2015
@k8s-bot
Copy link

k8s-bot commented Oct 27, 2015

GCE e2e test build/test passed for commit c3dfd30.

@wojtek-t
Copy link
Member

@k8s-bot unit test this please

1 similar comment
@ixdy
Copy link
Member

ixdy commented Oct 28, 2015

@k8s-bot unit test this please

@ashcrow
Copy link
Contributor

ashcrow commented Oct 28, 2015

@wojtek-t / @ixdy: That's two test requests in a row with no bot run for unit/integration.

@wojtek-t
Copy link
Member

@ashcrow - I don't understand - tests were run but they failed.

However, the failure:

11:10:56 �(B./hack/test-cmd.sh: line 492: file: command not found
11:10:56 error: there was a problem with the editor "cat"
11:10:56 !!! Error in ./hack/test-cmd.sh:492

seems like some infrastructural problem.
@ixdy - can you please take a look?

@ashcrow
Copy link
Contributor

ashcrow commented Oct 28, 2015

@wojtek-t my mistake. It looked like the same results from the previous runs and I thought it wasn't updating.

@ixdy
Copy link
Member

ixdy commented Oct 28, 2015

Looks like the containerized tests started failing after #16160. @jlowdermilk

@ixdy
Copy link
Member

ixdy commented Oct 28, 2015

@k8s-bot unit test this please

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Oct 29, 2015

GCE e2e test build/test passed for commit c3dfd30.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Oct 29, 2015
@k8s-github-robot k8s-github-robot merged commit e4924a4 into kubernetes:master Oct 29, 2015
@aveshagarwal aveshagarwal deleted the master-e2e-prestop branch November 5, 2015 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants