Dockerfile for jenkins build/test #16140
Conversation
k8s-github-robot
added
the
size/L
|
Labelling this PR as size/L |
|
GCE e2e build/test failed for commit 12f1e3109bbcab5bbf75b3efd5ffa023c905fcd3. |
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
There was a problem hiding this comment.
It's a short script, but it should probably still have the usual errexit/etc preamble unless there's a reason not to.
j3ffml
force-pushed
the
jenkins-test-image
branch
from
12f1e31 to
f3733e4
Compare
To allow jenkins to run verify/unit/cmd/integration tests in a container.
j3ffml
force-pushed
the
jenkins-test-image
branch
from
f3733e4 to
150ed6a
Compare
|
GCE e2e test build/test passed for commit 150ed6a. |
|
LGTM |
zmerlynn
added
the
lgtm
|
Manually merging. |
Dockerfile for jenkins build/test
| export KUBE_INTEGRATION_TEST_MAX_CONCURRENCY=4 | ||
| export LOG_LEVEL=4 | ||
|
|
||
| ./hack/verify-gofmt.sh |
There was a problem hiding this comment.
is there a particular reason to list these rather than using verify-all?
|
@ixdy, I'll open a follow up pr with fixes. I just wanted to get something semi-functional in to start testing it. |
|
Does this require a cherry-pick to build unit tests for release branch? |
|
@mikedanese, this version doesn't quite work so I'm actually just building the image on the pr-builder itself and putting commands directly into jenkins for now to get it working. So in the short term no, but later yes, since keeping detailed config in jenkins is bad (but also convenient). |
To allow jenkins to run unit/cmd/integration tests in a container, mapping in a repo dir and a test artifact output dir. Ref #14781
cc @ixdy