Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error on HEAD: Add JSONBase to v1beta3/types.go to prevent it #1580

Merged
merged 1 commit into from
Oct 4, 2014
Merged

Compilation error on HEAD: Add JSONBase to v1beta3/types.go to prevent it #1580

merged 1 commit into from
Oct 4, 2014

Conversation

ghodss
Copy link
Contributor

@ghodss ghodss commented Oct 4, 2014

On a clean checkout (at fd5a908), when I do go build ./..., I get a compilation error:

sghods-mba:kubernetes sam$ go build ./...
# github.com/GoogleCloudPlatform/kubernetes/pkg/api/v1beta3
pkg/api/v1beta3/types.go:839: undefined: JSONBase

I'm sure the intent was to fully remove JSONBase, but I don't know how to do that, so I did the minimal amount to just fix the build.

@bgrant0607
Copy link
Member

@smarterclayton

This is from the reference in EventList.

Please replace JSONBase with:

        TypeMeta `json:",inline" yaml:",inline"`
    Metadata ListMeta `json:"metadata,inline" yaml:"metadata,inline"`

As in OperationList.

@smarterclayton
Copy link
Contributor

It's fixed in another pull, but I won't have it ready until Monday or so.

bgrant0607 added a commit that referenced this pull request Oct 4, 2014
Compilation error on HEAD: Remove JSONBase reference from v1beta3/types.go to prevent it
@bgrant0607 bgrant0607 merged commit 2ac00df into kubernetes:master Oct 4, 2014
seans3 pushed a commit to seans3/kubernetes that referenced this pull request Apr 10, 2019
…ional-kep-owners

adds additional approvers and reviewers to KEPs OWNERS
harche pushed a commit to harche/kubernetes that referenced this pull request Jun 2, 2023
…able-4.13

OCPBUGS-13747: 4.13: kubelet/cm: disable cpu load balancing on slices when using static cpu manager policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants