Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ssh with net=host hostexec pod and kubectl exec in e2e tests where possible #15777

Merged
merged 1 commit into from
Nov 20, 2015
Merged

Replace ssh with net=host hostexec pod and kubectl exec in e2e tests where possible #15777

merged 1 commit into from
Nov 20, 2015
+130 −111

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Oct 16, 2015

  • added RunHostCmd to test/e2e/util.go to run a command in a shell in a hostexec container
  • ported kubeproxy e2e tests to hostexec
    • speed-up by parallel pod launch
    • speed-up pod delete with zero grace period
    • fix timeouts with blocking udp tests
  • ported privilegedPod e2e test to hostexec
  • ported NodePort e2e tests to hostexec
  • make all of them work with mesos/docker cluster

Prerequisites: #17101

NOTE: When #17101 is merged, commit 9e9df46 can be removed to use the gcr.io image.

@sttts sttts self-assigned this Oct 16, 2015
@sttts sttts force-pushed the sttts-replace-ssh-by-net-host-container branch from 04ea421 to e295562 Compare October 16, 2015 13:00
@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2015
@k8s-bot
Copy link

k8s-bot commented Oct 16, 2015

GCE e2e build/test failed for commit 04ea421ecb77f64d6467c74e2ad9cf59d32f9812.

@k8s-bot
Copy link

k8s-bot commented Oct 16, 2015

GCE e2e build/test failed for commit e295562a610b423a0420ef316edfe146f19a4061.

@sttts sttts changed the title Replace ssh in kubeproxy e2e tests by net=host container and kubectl exec WIP: Replace ssh in kubeproxy e2e tests by net=host container and kubectl exec Oct 16, 2015
@sttts sttts force-pushed the sttts-replace-ssh-by-net-host-container branch from e295562 to fd126fd Compare October 17, 2015 07:25
@k8s-bot
Copy link

k8s-bot commented Oct 17, 2015

GCE e2e build/test failed for commit fd126fdc0a06c3937ccc1a2a58c67dabb9c55a69.

@sttts sttts force-pushed the sttts-replace-ssh-by-net-host-container branch from fd126fd to 939c6dc Compare October 18, 2015 22:56
@k8s-bot
Copy link

k8s-bot commented Oct 18, 2015

GCE e2e build/test failed for commit 939c6dc79bf6db04b8b0ad64cd025987650e6a3a.

@sttts sttts force-pushed the sttts-replace-ssh-by-net-host-container branch 2 times, most recently from de16cec to 47d460f Compare October 19, 2015 10:04
@sttts sttts changed the title WIP: Replace ssh in kubeproxy e2e tests by net=host container and kubectl exec WIP: Replace ssh net=host hostexec container and kubectl exec in e2e tests where possible Oct 19, 2015
@k8s-bot
Copy link

k8s-bot commented Oct 19, 2015

GCE e2e build/test failed for commit de16cecede1da4d9d91ad1a1d5c3e7886395b18e.

@sttts
Copy link
Contributor Author

sttts commented Oct 19, 2015

/cc @ArtfulCoder should be ready soon. Comments are welcome.

@k8s-bot
Copy link

k8s-bot commented Oct 19, 2015

GCE e2e build/test failed for commit 47d460f411d3c8cb6f6c3f0a6bbe7ffd3f24f597.

@sttts sttts force-pushed the sttts-replace-ssh-by-net-host-container branch 2 times, most recently from 280f9b1 to 86bae1d Compare October 19, 2015 10:51
@sttts sttts changed the title WIP: Replace ssh net=host hostexec container and kubectl exec in e2e tests where possible WIP: Replace ssh with net=host hostexec container and kubectl exec in e2e tests where possible Oct 19, 2015
@k8s-bot
Copy link

k8s-bot commented Oct 19, 2015

GCE e2e test build/test passed for commit 280f9b15ea7bf27370521cce8dc6d40f8d7fdc2c.

@sttts sttts force-pushed the sttts-replace-ssh-by-net-host-container branch from 86bae1d to 92c0b6a Compare October 19, 2015 11:16
@sttts sttts changed the title WIP: Replace ssh with net=host hostexec container and kubectl exec in e2e tests where possible WIP: Replace ssh with net=host hostexec pod and kubectl exec in e2e tests where possible Oct 19, 2015
@sttts sttts changed the title WIP: Replace ssh with net=host hostexec pod and kubectl exec in e2e tests where possible Replace ssh with net=host hostexec pod and kubectl exec in e2e tests where possible Oct 19, 2015
@sttts
Copy link
Contributor Author

sttts commented Oct 19, 2015

/cc @jdef for review of contrib/mesos changes

@k8s-bot
Copy link

k8s-bot commented Oct 19, 2015

GCE e2e test build/test passed for commit 86bae1d6d7722c2e3862c865f64eebe25b745e19.

@k8s-bot
Copy link

k8s-bot commented Oct 19, 2015

GCE e2e build/test failed for commit 92c0b6ad4e4693d2fd8ae93d55a300fc5751d9c8.

@sttts sttts force-pushed the sttts-replace-ssh-by-net-host-container branch 2 times, most recently from 5fabf5a to 3309987 Compare November 17, 2015 13:46
@k8s-bot
Copy link

k8s-bot commented Nov 17, 2015

GCE e2e test build/test passed for commit e90d56abf014fafdbfc60c2f536fa210aa00945f.

@k8s-bot
Copy link

k8s-bot commented Nov 17, 2015

GCE e2e test build/test passed for commit 5fabf5aef1ee5b30ac85b0240eb27d36c14d006f.

@k8s-bot
Copy link

k8s-bot commented Nov 17, 2015

GCE e2e test build/test passed for commit 330998709eceaa1d772bf459e6e39a2fce0045cf.

ArtfulCoder
ArtfulCoder reviewed Nov 17, 2015
View reviewed changes
test/e2e/kubeproxy.go
{
Name: "host",
ContainerPort: endpointHttpPort,
HostPort: endpointHostPort,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we make sure that the pod is created on every host ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare the nodeName and line 479.

@sttts
e2e: replace ssh with net=host hostexec pod and kubectl exec
2d6c2eb 
- document needed packages in hostexec image
- add RunHostCmdOrDie
- kube-proxy e2e: port from ssh to hostexec
  - use preset NodeName to schedule test pods to different nodes
  - parallel launch of pods
  - port from ssh to hostexec
  - add timeout because nc might block on udp
  - delete test container without grace period
- PrivilegedPod e2e: port from ssh to hostexec
- NodePort e2e: port from ssh to hostexec
- cluster/mesos/docker: Enable privileged pods
@sttts sttts force-pushed the sttts-replace-ssh-by-net-host-container branch from 3309987 to 2d6c2eb Compare November 17, 2015 19:49
@sttts
Copy link
Contributor Author

sttts commented Nov 17, 2015

@ArtfulCoder squashed.

@k8s-bot
Copy link

k8s-bot commented Nov 17, 2015

GCE e2e build/test failed for commit 2d6c2eb.

@sttts
Copy link
Contributor Author

sttts commented Nov 17, 2015

@k8s-bot test this

@k8s-bot
Copy link

k8s-bot commented Nov 17, 2015

GCE e2e build/test failed for commit 2d6c2eb.

@sttts
Copy link
Contributor Author

sttts commented Nov 17, 2015

e2e broken again? "Cluster failed to initialize within 300 seconds". Exactly same code as before, only squashed.

@sttts
Copy link
Contributor Author

sttts commented Nov 17, 2015

@k8s-bot test this

@k8s-bot
Copy link

k8s-bot commented Nov 17, 2015

GCE e2e test build/test passed for commit 2d6c2eb.

@sttts
Copy link
Contributor Author

sttts commented Nov 19, 2015

@ArtfulCoder ptal

@ArtfulCoder ArtfulCoder added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2015
@ArtfulCoder
Copy link
Contributor

Thank you for the changes!

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Nov 20, 2015

GCE e2e build/test failed for commit 2d6c2eb.

@sttts
Copy link
Contributor Author

sttts commented Nov 20, 2015

@k8s-bot test this

@k8s-bot
Copy link

k8s-bot commented Nov 20, 2015

GCE e2e test build/test passed for commit 2d6c2eb.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Nov 20, 2015

GCE e2e test build/test passed for commit 2d6c2eb.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Nov 20, 2015
Merge pull request #15777 from mesosphere/sttts-replace-ssh-by-net-ho…
1a57cc8 
…st-container

Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 1a57cc8 into kubernetes:master Nov 20, 2015
@mikedanese mikedanese mentioned this pull request Nov 30, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ArtfulCoder ArtfulCoder

Labels
area/test area/test-infra lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sttts @k8s-github-robot @k8s-bot @jdef @ArtfulCoder @k8s-teamcity-mesosphere @googlebot