Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hardcode componentStatus's namespace to "default" #15689

Merged
merged 2 commits into from
Oct 17, 2015
Merged

hardcode componentStatus's namespace to "default" #15689

merged 2 commits into from
Oct 17, 2015

Conversation

caesarxuchao
Copy link
Member

fix #15618

It's a temporary fix before @karlkfi make a replacement.

@dkorn @kalkfi @lavalamp

@caesarxuchao caesarxuchao added team/cluster sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 15, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 15, 2015
@k8s-bot
Copy link

k8s-bot commented Oct 15, 2015

GCE e2e test build/test passed for commit 51754c247ac2e3d0e98a8d1cb486a852c9705197.

@lavalamp
Copy link
Member

perhaps kube-system is better than default, even for a quick hack?

@lavalamp
Copy link
Member

but actually, a better fix is making it not namespaced at all, as long as that doesn't break anything.

@caesarxuchao caesarxuchao force-pushed the default-ns-componentstatus branch from 508fd20 to b934d7d Compare October 16, 2015 05:39
@caesarxuchao
Copy link
Member Author

@lavalamp I thought you meant ComponentStatus should remain namespaced for the future. Anyway, I made it not namespaced. PTAL. Thank you!

@k8s-bot
Copy link

k8s-bot commented Oct 16, 2015

GCE e2e test build/test passed for commit 508fd2020cd7b9a37de9fa3c90378c264f8b8cc0.

@k8s-github-robot
Copy link

Labelling this PR as size/XXL

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2015
@k8s-bot
Copy link

k8s-bot commented Oct 16, 2015

GCE e2e test build/test passed for commit b934d7da64006836d6cb0f31d749cf3ccbf78c4e.

karlkfi
karlkfi reviewed Oct 16, 2015
View reviewed changes
docs/api-reference/definitions.html
@@ -1918,6 +1914,12 @@ <h3 id="_v1_nodelist">v1.NodeList</h3>

</div>
<div class="sect2">
<h3 id="_unversioned_patch">unversioned.Patch</h3>
<div class="paragraph">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the patch and security context stuff changing in the definitions file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because some other PR changed swagger but hadn't run the script that regenerates the definitions file..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove the changes from this PR. There is no ComponentStatus related change.

@caesarxuchao caesarxuchao force-pushed the default-ns-componentstatus branch from b934d7d to d6223a8 Compare October 16, 2015 17:25
caesarxuchao
caesarxuchao reviewed Oct 16, 2015
View reviewed changes
api/swagger-spec/v1.json
@@ -182,73 +166,6 @@
]
},
{
"path": "/api/v1/componentstatuses",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this path is removed from swagger. The path still exists.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it got moved up to where the namespaced one was. git diff just can't keep up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thanks.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 16, 2015
@k8s-bot
Copy link

k8s-bot commented Oct 16, 2015

GCE e2e test build/test passed for commit d6223a8.

@karlkfi
Copy link
Contributor

karlkfi commented Oct 16, 2015

This LGTM, but it's not technically reverse compatible. I assume @lavalamp is ok with that, since he suggested it. Please confirm.

@lavalamp
Copy link
Member

Before we merge-- @roberthbailey can you verify that GKE monitors the non-namespaced path?

(I think GKE is the big client for this API)

@roberthbailey
Copy link
Contributor

We hit https://<endpoint>/api/v1/componentstatuses so it looks like this will still work (and we'll find out if I'm wrong right away if gke-ci does red).

/cc @fabioy

@lavalamp
Copy link
Member

OK, I think everyone who cares about this is in this PR, so LGTM. We don't need to cherrypick.

@karlkfi karlkfi added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2015
@k8s-github-robot
Copy link

Continuous integration appears to have missed, closing and re-opening to trigger it

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Oct 17, 2015

GCE e2e test build/test passed for commit d6223a8.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Oct 17, 2015
Merge pull request #15689 from caesarxuchao/default-ns-componentstatus
d41737e 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit d41737e into kubernetes:master Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@karlkfi karlkfi

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken selflink for a specific component status
8 participants
@caesarxuchao @k8s-github-robot @k8s-bot @lavalamp @karlkfi @roberthbailey @k8s-teamcity-mesosphere @googlebot