Change "experimental" to "beta" in annotations #15414
Conversation
k8s-github-robot
added
the
size/M
|
Labelling this PR as size/M |
|
You're going to break existing annotations without backward compatibility? |
|
Nevermind, I see the code looks at both. |
| @@ -2838,7 +2838,7 @@ func validateBandwidthIsReasonable(rsrc *resource.Quantity) error { | |||
| } | |||
|
|
|||
| func extractBandwidthResources(pod *api.Pod) (ingress, egress *resource.Quantity, err error) { | |||
| str, found := pod.Annotations["kubernetes.io/ingress-bandwidth"] | |||
| str, found := pod.Annotations["net.beta.kubernetes.io/ingress-bandwidth"] | |||
There was a problem hiding this comment.
And, if so, why not do the same compatibility dance?
There was a problem hiding this comment.
fwiw, i just started evaluating this last week, i cannot imagine there is wide use as it didn't get much in the way of documentation to my knowledge
There was a problem hiding this comment.
That was my feeling too, so I was lazy. I am fine with alpha, or can do
the compat dance...
On Oct 9, 2015 5:48 PM, "Derek Carr" notifications@github.com wrote:
In pkg/kubelet/kubelet.go
#15414 (comment)
:@@ -2838,7 +2838,7 @@ func validateBandwidthIsReasonable(rsrc *resource.Quantity) error {
}func extractBandwidthResources(pod *api.Pod) (ingress, egress *resource.Quantity, err error) {
- str, found := pod.Annotations["kubernetes.io/ingress-bandwidth"]
- str, found := pod.Annotations["net.beta.kubernetes.io/ingress-bandwidth"]
fwiw, i just started evaluating this last week, i cannot imagine there is
wide use as it didn't get much in the way of documentation to my knowledge—
Reply to this email directly or view it on GitHub
https://github.com/kubernetes/kubernetes/pull/15414/files#r41690399.
|
GCE e2e test build/test passed for commit 966f4c0bdfe8d0600eca7a4656424650d3063729. |
thockin
force-pushed
the
exp-beta-annotations
branch
from
966f4c0 to
2f4c303
Compare
|
pushed as "alpha" |
|
GCE e2e test build/test passed for commit 2f4c303. |
|
I'm sure we'll need to rethink these in the future, but good enough for now. |
bgrant0607
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 2f4c303. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
…4-upstream-release-1.1 Automated cherry pick of #15414 upstream release 1.1
…k-of-#15414-upstream-release-1.1 Automated cherry pick of kubernetes#15414 upstream release 1.1
Auto commit by PR queue bot
…k-of-#15414-upstream-release-1.1 Automated cherry pick of kubernetes#15414 upstream release 1.1
@bgrant0607 @brendandburns