podex: initial import #1537
podex: initial import #1537
Conversation
| // | ||
| // Example usage: | ||
| // | ||
| // $ docker pull google/nodejs-hello |
There was a problem hiding this comment.
No way to inspect without pulling?
There was a problem hiding this comment.
Maybe using the docker-registry/hub API, but I couldn't get it to work. So I gave up and used the remote API for now.
I will add a TODO.
|
First big issue - do we want to check stuff like this into kubernetes tree directly? If so, where? I'm OK with checking in small, highly coupled stuff in here, but there's a line somewhere. E.g. heapster is a separate project. Assuming we're OK with checking it in, where? I'd say this goes in contrib/podex You need a README.md and a MAINTAINERS.md so it is very clear that this is not a core piece (i.e. not guaranteed to stay functional) |
|
@thockin Done. PTAL |
|
|
||
| ## OS Distributions | ||
|
|
||
| * RedHat, Fedora: [Clayton Coleman](https://github.com/smarterclayton), [Derek Carr](https://github.com/derekwaynecarr), [Scott Collier](https://github.com/scollier) |
There was a problem hiding this comment.
Why did you import the whole top-level MAINTAINERS here?
There was a problem hiding this comment.
ahah because I wanted to reuse the structure, and forgot to clean it up :)
There was a problem hiding this comment.
Ping me when done, I'll merge
On Thu, Oct 2, 2014 at 5:24 PM, Johan Euphrosine notifications@github.com
wrote:
In contrib/podex/MAINTAINERS.md:
@@ -0,0 +1,18 @@
+# Maintainers
+
+People responsible for ports of Kubernetes to different environments. CC at least one maintainer on relevant issues and PRs.
+
+## OS Distributions
+
+* RedHat, Fedora: Clayton Coleman, Derek Carr, Scott Collierahah because I wanted to reuse the structure, and forgot to clean it up :)
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/1537/files#r18376338
.
|
LGTM after last comments |
|
@thockin Thanks for the quick review. |
…tion UPSTREAM: <carry>: add shutdown annotation to response header
podex is a command line tool to bootstrap a kubernetes container manifests from docker image metadata.
Manifests can then be edited by a human to match deployment needs.
Example usage:
The
podex/manifestssubdirectory could also be used to host example pods for popular docker images.