Minor documentation formatting cleanup. #15353
Conversation
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
| 1. Add the clusters network to the bridge (docker will go on other side of bridge). | ||
| - e.g. `ip addr add $NODE_X_BRIDGE_ADDR dev cbr0` | ||
| - `ip addr add $NODE_X_BRIDGE_ADDR dev cbr0` |
There was a problem hiding this comment.
nit: Maybe say $YOUR_NODE_X_BRIDGE_ADDR or another way of telling the user that it's not some automatically created environment variable. I think most people would figure it out upon initial reading but without the e.g. for this line I could see some people misunderstanding.
There was a problem hiding this comment.
Sounds reasonable to me. FWIW, $NODE_X_BRIDGE_ADDR is mentioned in the preceding paragraph so that would need to be changed as well for consistency.
There was a problem hiding this comment.
I don't think YOUR adds much here. If you want to change this I would say THIS_NODE_BRIDGE_ADDR
|
One nit noted. The changes make sense. |
| - `ip link set dev cbr0 mtu 1460` (NOTE: the actual value of MTU will depend on your network environment) | ||
| - `brctl addbr cbr0`. | ||
| 1. Set appropriate MTU. NOTE: the actual value of MTU will depend on your network environment | ||
| - `ip link set dev cbr0 mtu 1460` | ||
| 1. Add the clusters network to the bridge (docker will go on other side of bridge). |
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
thockin
added
ok-to-merge
lgtm
|
Manually merging because I can't get shippable status to go away |
Minor documentation formatting cleanup.
Formatting improvements to the scratch doc's networking section.