Error checks from waitForEndoint in e2e examples tests #15152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GCE e2e test build/test passed for commit 555cc5e. |
k8s-github-robot
added
the
size/S
|
Labelling this PR as size/S |
| @@ -148,7 +148,8 @@ var _ = Describe("Examples e2e", func() { | |||
| _, err := lookForStringInLog(ns, pod.Name, "rabbitmq", "Server startup complete", serverStartTimeout) | |||
| Expect(err).NotTo(HaveOccurred()) | |||
| }) | |||
| waitForEndpoint(c, ns, "rabbitmq-service") | |||
| err := waitForEndpoint(c, ns, "rabbitmq-service") | |||
There was a problem hiding this comment.
how about expectNoError(waitForEndpoint(c, ns, "rabbitmq-service"))?
There was a problem hiding this comment.
In this file cluster control is not mixed with assertions (in a single line).
|
LGTM |
piosz
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 555cc5e. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Oct 6, 2015
Auto commit by PR queue bot
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…-pick-of-#11694-kubernetes#14984-kubernetes#15152-kubernetes#15445-kubernetes#15875-kubernetes#16473-kubernetes#16979-upstream-release-1.1 Automated cherry pick of kubernetes#11694 kubernetes#14984 kubernetes#15152 kubernetes#15445 kubernetes#15875 kubernetes#16473 kubernetes#16979
shouhong
pushed a commit
to shouhong/kubernetes
that referenced
this pull request
Feb 14, 2017
…-pick-of-#11694-kubernetes#14984-kubernetes#15152-kubernetes#15445-kubernetes#15875-kubernetes#16473-kubernetes#16979-upstream-release-1.1 Automated cherry pick of kubernetes#11694 kubernetes#14984 kubernetes#15152 kubernetes#15445 kubernetes#15875 kubernetes#16473 kubernetes#16979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.