Don't print Kubernetes username/password to console. #1494
Merged
+65
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is too easy to copy/paste this on-line. Fixes kubernetes#1483
|
@filbranden No need to fix up all the bash-isms here but rather a sanity check. It is hard to actually run/test all of these out so a careful review will be helpful. |
|
Looks good. Do the whitespace fixes need to be in the same commit as the parts that strip username/password from the console output? It would be better if they were in separate commits (even if it's in the same pull request) but if you're OK with both of them together then that's fine with me. |
|
My editor does it by default. It'd be a pain to figure out how to separate it out. |
filbranden
added a commit
that referenced
this pull request
Sep 29, 2014
Don't print Kubernetes username/password to console.
gnufied
pushed a commit
to gnufied/kubernetes
that referenced
this pull request
Mar 3, 2023
Bump to k8s 1.26.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is too easy to copy/paste this on-line.
Fixes #1483