Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added README file to Resource Consumer #14645

Merged
merged 1 commit into from
Oct 3, 2015
Merged

added README file to Resource Consumer #14645

merged 1 commit into from
Oct 3, 2015

Conversation

socaa
Copy link

@socaa socaa commented Sep 28, 2015

Part of #11570

@piosz

@k8s-bot
Copy link

k8s-bot commented Sep 28, 2015

Unit, integration and GCE e2e test build/test passed for commit a0bcf64022ceef2e7f2d744012645a23ae7994ef.

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 28, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/M

@piosz piosz assigned piosz and unassigned ixdy Sep 28, 2015
@piosz
Copy link
Member

piosz commented Sep 28, 2015

cc @mwielgus @jszczepkowski

@jszczepkowski
Copy link
Contributor

Fine so far, but can you extend it a bit? E.g.:

  • tell more how the consumer is implemented,
  • tell on which port it listens, is the port configurable?

@piosz
Copy link
Member

piosz commented Sep 28, 2015

What Resource Consumer is?
What it could be used for?

@jszczepkowski
Copy link
Contributor

Also some examples usage can be added, something like:
curl xxx | echo "yyy"

@socaa
Copy link
Author

socaa commented Sep 29, 2015

PTAL

@piosz
@jszczepkowski

@k8s-bot
Copy link

k8s-bot commented Sep 29, 2015

Unit, integration and GCE e2e test build/test passed for commit bfbbe7000952a187198545d06020d379583996b5.

piosz
piosz reviewed Sep 29, 2015
View reviewed changes
test/images/resource-consumer/README.md
@@ -0,0 +1,66 @@
# Resource Consumer container for testing

Resource Consumer is a tool for testing kubernetes autoscaling.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would start with something like: a tool which allows to generate cpu/memory utilization ...
and then write something about the reason why it was created (testing autoscaling)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jszczepkowski
Copy link
Contributor

There seems to be one important limitation, that needs to be mentioned in this doc: one replica of consumer cannot consume more that 1 cpu.

@socaa socaa force-pushed the readme branch 5 times, most recently from 9066da1 to d815736 Compare September 29, 2015 12:35
@k8s-bot
Copy link

k8s-bot commented Sep 29, 2015

Unit, integration and GCE e2e build/test failed for commit 2c3f2973cebb6b8df838e88bbcd285c5867e80aa.

@socaa socaa force-pushed the readme branch 3 times, most recently from a2aeb81 to c8ff218 Compare September 29, 2015 12:40
@socaa
Copy link
Author

socaa commented Sep 29, 2015

PTAL

@piosz
@jszczepkowski

@k8s-bot
Copy link

k8s-bot commented Sep 29, 2015

Unit, integration and GCE e2e test build/test passed for commit e2ed18e52e4d9539b63cea6b89d6f36f2fdb1c4f.

@jszczepkowski
Copy link
Contributor

This is the last bunch of my comments, LGTM after they are applied.

@socaa
Copy link
Author

socaa commented Sep 30, 2015

PTAL

@piosz
@jszczepkowski

@k8s-bot
Copy link

k8s-bot commented Sep 30, 2015

Unit, integration and GCE e2e build/test failed for commit 7069731bfddfb1c848d40d209a37bf57f91dbb60.

jszczepkowski
jszczepkowski reviewed Sep 30, 2015
View reviewed changes
test/images/resource-consumer/README.md
Consume Memory uses stress tool (stress -m 1 --vm-bytes megabytes --vm-hang 0 -t durationSec).

###CURL example
* $ kubectl run resource-consumer --image=gcr.io/google_containers/resource_consumer:beta,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace items with:

xxx

@jszczepkowski
Copy link
Contributor

LGTM

@socaa
Copy link
Author

socaa commented Sep 30, 2015

PTAL

@piosz
@jszczepkowski

@k8s-bot
Copy link

k8s-bot commented Sep 30, 2015

Unit, integration and GCE e2e test build/test passed for commit 6726bac0e5cf34c4c9697fc051b23164e362de10.

derekwaynecarr
derekwaynecarr reviewed Sep 30, 2015
View reviewed changes
test/images/resource-consumer/README.md
- parameters "megabytes" and "durationSec".

Consumes specified amount of megabytes for durationSec seconds.
Consume Memory uses stress tool (stress -m 1 --vm-bytes megabytes --vm-hang 0 -t durationSec).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its important to note some things that caught me by surprise when using this tool.

Specifically, the following:

  1. It is not possible to induce a SystemOOM event using this container.
  2. If you request more memory that what is available on the node, the request will be ignored completely, and no feeback is given to the user. This is a product of using the underlying stress tool.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@derekwaynecarr
Copy link
Member

@jszczepkowski - a simple way to consume more than 1 cpu on the node is to do the following:

cluster/kubectl.sh run cpuhog \
    --image=busybox \
    -- md5sum /dev/urandom

In case you need it in the future.

@socaa
Copy link
Author

socaa commented Oct 1, 2015

PTAL

@jszczepkowski
@piosz

@k8s-bot
Copy link

k8s-bot commented Oct 1, 2015

Unit, integration and GCE e2e test build/test passed for commit ce5d7d4.

@piosz
Copy link
Member

piosz commented Oct 1, 2015

LGTM

@piosz piosz added lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels Oct 1, 2015
@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@piosz piosz closed this Oct 2, 2015
@piosz piosz reopened this Oct 2, 2015
@k8s-github-robot
Copy link

Automatic merge from submit-queue

1 similar comment
@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Oct 3, 2015
Merge pull request #14645 from socaa/readme
ffacd3b 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit ffacd3b into kubernetes:master Oct 3, 2015
@piosz piosz mentioned this pull request Oct 5, 2015
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@piosz piosz

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@socaa @k8s-bot @k8s-github-robot @piosz @jszczepkowski @derekwaynecarr @googlebot @ixdy