Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of generate BASIC_AUTH_FILE file #14637

Merged

Conversation

alfred-huangjian
Copy link
Contributor

The basic auth file format is (paasword, user name, user uid)
The vagrant cluster generate the basic auth file with a wrong order of paasword and username.

@k8s-bot
Copy link

k8s-bot commented Sep 28, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 28, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@ashcrow
Copy link
Contributor

ashcrow commented Sep 30, 2015

Makes sense to me.

As the admin authentication doc notes:

The basic auth file format is implemented in plugin/pkg/auth/authenticator/password/passwordfile/... and is a csv file with 3 columns: password, user name, user id.

@ashcrow
Copy link
Contributor

ashcrow commented Oct 9, 2015

cc @eparis

@k8s-bot
Copy link

k8s-bot commented Jan 28, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Jan 28, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Feb 6, 2016

GCE e2e test build/test passed for commit f80120d.

@bgrant0607 bgrant0607 assigned derekwaynecarr and unassigned eparis Feb 18, 2016
@derekwaynecarr
Copy link
Member

LGTM - never saw a problem because user and password were the same value.

@derekwaynecarr derekwaynecarr added lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels Feb 24, 2016
@k8s-github-robot
Copy link

@k8s-bot ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-bot
Copy link

k8s-bot commented Feb 25, 2016

GCE e2e test build/test passed for commit f80120d.

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Feb 26, 2016
@k8s-github-robot k8s-github-robot merged commit 54a684a into kubernetes:master Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants