-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue of generate BASIC_AUTH_FILE file #14637
Fix the issue of generate BASIC_AUTH_FILE file #14637
Conversation
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
Labelling this PR as size/XS |
Makes sense to me. As the admin authentication doc notes:
|
cc @eparis |
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
1 similar comment
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
GCE e2e test build/test passed for commit f80120d. |
LGTM - never saw a problem because user and password were the same value. |
GCE e2e test build/test passed for commit f80120d. |
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
Automatic merge from submit-queue |
Auto commit by PR queue bot
The basic auth file format is (paasword, user name, user uid)
The vagrant cluster generate the basic auth file with a wrong order of paasword and username.