Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cassandra example according to config best practices #14623

Merged
merged 1 commit into from
Nov 25, 2015

Conversation

linzichang
Copy link
Contributor

related to #11361

@k8s-bot
Copy link

k8s-bot commented Sep 27, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 27, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/M

@bgrant0607
Copy link
Member

Awaiting resolution of #14256

@k8s-bot
Copy link

k8s-bot commented Oct 29, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@bgrant0607
Copy link
Member

@linzichang Please rebase and squash the commits. I'd like to get this in before more significant changes.

@bgrant0607 bgrant0607 assigned janetkuo and unassigned bgrant0607 Nov 10, 2015
@bgrant0607
Copy link
Member

cc @jeffmendoza @amygdala

@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2015
@janetkuo
Copy link
Member

@k8s-bot ok to test

@k8s-github-robot
Copy link

@k8s-bot ok to test

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

Continuous integration appears to have missed, closing and re-opening to trigger it

@k8s-bot
Copy link

k8s-bot commented Nov 25, 2015

GCE e2e test build/test passed for commit 51dd067.

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Nov 25, 2015
@k8s-github-robot k8s-github-robot merged commit 3136aca into kubernetes:master Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants