Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jenkins shell script to setup and run verification tests #14587

Merged
merged 2 commits into from
Oct 20, 2015
Merged

Add Jenkins shell script to setup and run verification tests #14587

merged 2 commits into from
Oct 20, 2015

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Sep 25, 2015

We need to install some dependencies to run the various hack/verify* scripts.
May as well bundle this into another script under hack/jenkins.

@ixdy
Copy link
Member Author

ixdy commented Sep 25, 2015

@kubernetes/goog-testing
I don't understand why hack/verify-generated-docs.sh is failing still on Jenkins, but I think it's a separate issue from this PR.

@k8s-bot
Copy link

k8s-bot commented Sep 25, 2015

Unit, integration and GCE e2e test build/test passed for commit 8029743d802faff45eef26cb1bee32d73e316865.

@k8s-bot
Copy link

k8s-bot commented Sep 25, 2015

Unit, integration and GCE e2e test build/test passed for commit 1b1920d26f73047f4155b010e6319fd1420154c4.

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 25, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-bot
Copy link

k8s-bot commented Sep 25, 2015

Unit, integration and GCE e2e build/test failed for commit cc9e2d64c18ae2a4ccf61c332ea6c09552ddeaa3.

@k8s-bot
Copy link

k8s-bot commented Sep 29, 2015

Unit, integration and GCE e2e test build/test passed for commit 8b3760d099e6cb2abce7300ed10ce22a878bc53f.

@ixdy
Copy link
Member Author

ixdy commented Sep 29, 2015

The verification checks appear to be working, besides the etcd issue mentioned in #14781.

@ixdy ixdy mentioned this pull request Oct 5, 2015
Closed
@k8s-bot
Copy link

k8s-bot commented Oct 6, 2015

Unit, integration and GCE e2e test build/test passed for commit d3b4d1b571f8bf5c7c4b30eabbdb63040eeb9e75.

@k8s-bot
Copy link

k8s-bot commented Oct 12, 2015

GCE e2e test build/test passed for commit d3b4d1b571f8bf5c7c4b30eabbdb63040eeb9e75.

@k8s-bot
Copy link

k8s-bot commented Oct 14, 2015

GCE e2e test build/test passed for commit f32185a2d0840f821aa9e7f33454ab8c89d16148.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2015
@zmerlynn
Copy link
Member

Sigh. I'm sorry for the forever it took me to get to this. Rebase?

@ixdy
Copy link
Member Author

ixdy commented Oct 15, 2015

No worries. Also, the etcd check should work after #15586 (though more work is needed there)

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2015
@k8s-bot
Copy link

k8s-bot commented Oct 15, 2015

GCE e2e test build/test passed for commit bab5b2cea78fd99531328e554df0c2e904a8c1e9.

zmerlynn
zmerlynn reviewed Oct 19, 2015
View reviewed changes
hack/jenkins/verify.sh
set -o errexit
set -o nounset
set -o pipefail
set -o xtrace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I basically cargo-culted this file from the other scripts in hack/jenkins. All of them set xtrace, though maybe we should change that?

I did notice that my comment on L17-18 was wrong, so that's been fixed now at least.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ignore me, yes.

@zmerlynn
Copy link
Member

LGTM modulo question. Are you saying we need to wait on #15586 to merge?

@ixdy
Ignore _gopath in verify scripts
4cafa3e 
The _gopath directory is used in Jenkins to install extra dependencies,
and any files in it should be ignored by the various verification
scripts.
@ixdy
Copy link
Member Author

ixdy commented Oct 19, 2015

We don't need to necessarily wait on #15586 to merge this, but we can't really enable the tests on PR Jenkins until the etcd issue is addressed.

@k8s-bot
Copy link

k8s-bot commented Oct 19, 2015

GCE e2e test build/test passed for commit abdaa75c4576013f4a8c06aeeb25978ee9ada756.

@k8s-bot
Copy link

k8s-bot commented Oct 19, 2015

GCE e2e test build/test passed for commit 1016b49.

@zmerlynn
Copy link
Member

LGTM

@zmerlynn zmerlynn added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2015
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Oct 20, 2015

GCE e2e test build/test passed for commit 1016b49.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Oct 20, 2015
Merge pull request #14587 from ixdy/jenkins-verify
37afbf6 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 37afbf6 into kubernetes:master Oct 20, 2015
@ixdy ixdy deleted the jenkins-verify branch December 1, 2015 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmerlynn zmerlynn

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ixdy @k8s-bot @k8s-github-robot @zmerlynn @k8s-teamcity-mesosphere @googlebot