PersistentVolume Provisioner Controller #14537

markturansky · 2015-09-25T04:46:17Z

See #6773

Added support for dynamically provisioning HostPath PVs for test and development.

@thockin @saad-ali @kubernetes/rh-storage

The first commit will drop out when #14249 is merged.

markturansky · 2015-09-25T04:46:50Z

Requires integration tests.

k8s-bot · 2015-09-25T05:03:49Z

GCE e2e build/test failed for commit e0607ba72487000cf2b54bc3001af64301229cf3.

k8s-bot · 2015-09-25T05:13:40Z

GCE e2e build/test failed for commit 7b23912c76dd0249b7966311f89ab70fee610882.

markturansky · 2015-09-25T05:19:18Z

pkg/controller/persistentvolume/persistentvolume_provisioner_controller.go

+	glog.V(5).Infof("Starting PersistentVolumeProvisioner\n")
+	if provisioner.stopChannel == nil {
+		provisioner.stopChannel = make(chan struct{})
+		go provisioner.pvclaimController.Run(provisioner.stopChannel)


this needs to be like the binder and handle two stop channels for the two controllers.

k8s-github-robot · 2015-09-25T05:49:34Z

Labelling this PR as size/XL

pmorie · 2015-09-25T05:51:52Z

pkg/controller/persistentvolume/persistentvolume_index_test.go

@@ -484,3 +484,78 @@ func createTestVolumes() []*api.PersistentVolume {
 		},
 	}
 }
+
+func TestFindingPreboundVolumes(t *testing.T) {
+	pv1 := &api.PersistentVolume{


Extract an object mother like:

func pvFor(size int) *api.PersistentVolume { sz := strconv.Itoa(size) return &api.PersistentVolume{ ObjectMeta: api.ObjectMeta{ Name: fmt.Sprintf("pv%v", sz), Annotations: map[string]string{}, }, Spec: api.PersistentVolumeSpec{ Capacity: api.ResourceList{api.ResourceName(api.ResourceStorage): resource.MustParse(fmt.Sprintf("%vGi", sz))}, PersistentVolumeSource: api.PersistentVolumeSource{HostPath: &api.HostPathVolumeSource{}}, AccessModes: []api.PersistentVolumeAccessMode{api.ReadWriteOnce}, }, } }

k8s-bot · 2015-09-29T14:21:23Z

Unit, integration and GCE e2e build/test failed for commit cbdd44d2a0db0525f0309279f5d9cea2e6be44d8.

k8s-bot · 2015-09-29T15:07:13Z

Unit, integration and GCE e2e build/test failed for commit 40005777882e13cde22f3394e23ae0ceb16acd8a.

jsafrane · 2015-09-29T16:07:05Z

pkg/controller/persistentvolume/persistentvolume_provisioner_controller.go

+	glog.V(5).Infof("Provisioning PersistentVolumeClaim[%s/%s]\n", pvc.Namespace, pvc.Name)
+
+	volumeOptions := volume.VolumeOptions{
+		CapacityMB:                    100,


The volume size must come from the claim, otherwise it creates only 100MB volumes.

yes, this is a placeholder. Need to convert from the pvc into MB.

actually, i think the factoring is wrong. This should be resource.Quantity and copied from the claim.

saad-ali · 2015-09-30T04:40:56Z

I'll look at this first thing in the morning @markturansky
Sorry for the delay

markturansky · 2015-09-30T12:37:16Z

@saad-ali thanks, but give me until the end of today to push my latest changes, tests, etc. Got a few nits to pick first. I'll ping when ready.

k8s-bot · 2015-12-10T21:57:41Z

GCE e2e build/test failed for commit f93be02dafed3dc322e7d1ba009b643de91d8324.

markturansky · 2015-12-10T23:22:47Z

@saad-ali cloud providers removed for now and for Jan to add back.

k8s-bot · 2015-12-11T00:08:38Z

GCE e2e test build/test passed for commit e9488ead15819674e8915f615ca1fee658b63698.

saad-ali · 2015-12-11T00:26:55Z

cmd/kube-controller-manager/app/plugins.go

 		glog.Fatalf("Could not create NFS recycler pod from file %s: %+v", flags.PersistentVolumeRecyclerPodTemplateFilePathNFS, err)
 	}
 	allPlugins = append(allPlugins, nfs.ProbeVolumePlugins(nfsConfig)...)

+	allPlugins = append(allPlugins, aws_ebs.ProbeVolumePlugins()...)
+	allPlugins = append(allPlugins, gce_pd.ProbeVolumePlugins()...)


There are no recyclers defined for these plugins yet. Will that break anything?

No. All is well.

jsafrane · 2015-12-11T11:12:49Z

cloud providers removed for now and for Jan to add back.

Ok, I added them back in my PRs, but now they may conflict with each other, as they modify the same code.

pmorie · 2015-12-11T15:01:49Z

@markturansky rebase needed

markturansky · 2015-12-11T15:16:31Z

pkg/controller/persistentvolume/types.go

+		// and will match above when the claim is re-processed by the binder.
+		if keyExists(qosProvisioningKey, claim.Annotations) {
+			return nil, nil
+		}


@saad-ali The binder will ignore a claim with the provisioningKey if it's not an exact match with a volume (i.e, the volume has a ClaimRef of the claim). This might be non-obvious in the controller (though I have comments there saying so), but this block of code is where it is enforced. Claims only bind to volumes provisioned for it, if the annotation is present.

I think I buy this argument, but the controller interaction isn't obvious here.

Ok, so basically the provisioner controller only acts on PVCs that have the volume annotation, and the binder control just ignores PVCs that DO have the volume annotation?

markturansky · 2015-12-11T15:28:19Z

@saad-ali @pmorie rebased.

Also added a small bit that only allows claims to bind when its volume (created specifically for it) is fully provisioned. Also added a comment to make clear that claims will only bind to the volume w/ ClaimRef of the claim (when provisioning is requested).

k8s-bot · 2015-12-11T16:02:14Z

GCE e2e build/test failed for commit 4fc1bf1.

markturansky · 2015-12-11T16:04:46Z

@k8s-bot test this

k8s-bot · 2015-12-11T16:10:58Z

GCE e2e test build/test passed for commit 916c1e9560a761236b0e3e79172aeea3226a6bcc.

k8s-bot · 2015-12-11T16:45:19Z

GCE e2e test build/test passed for commit 4fc1bf1.

saad-ali · 2015-12-11T18:41:41Z

Taking a look now.

saad-ali · 2015-12-11T19:17:06Z

LGTM

markturansky · 2015-12-11T19:28:26Z

@k8s-oncall Please merge? We are held up by this PR downstream and need to rebase another one from this. All lights are green and have LGTM tag.

pmorie · 2015-12-11T19:40:13Z

In the interest of full disclosure, there are 3 PRs we need to rebase on top of this and get in for OpenShift 3.1.1 today, so if the @k8s-oncall dev could take a look and merge, we would appreciate it.

PersistentVolume Provisioner Controller

wattsteve · 2015-12-11T21:14:24Z

Woohoo. Nice work @markturansky. Thanks @pmorie @saad-ali @childsb @jsafrane for all the reviews.

googlebot added the cla: yes label Sep 25, 2015

markturansky force-pushed the pv_provisioner branch from e0607ba to 7b23912 Compare September 25, 2015 04:55

markturansky reviewed Sep 25, 2015
View reviewed changes

k8s-github-robot assigned davidopp Sep 25, 2015

k8s-github-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 25, 2015

pmorie reviewed Sep 25, 2015
View reviewed changes

saad-ali mentioned this pull request Sep 25, 2015

Add flocker volume plugin #14328

Merged

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2015

davidopp added team/cluster priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 27, 2015

davidopp assigned thockin and unassigned davidopp Sep 27, 2015

markturansky force-pushed the pv_provisioner branch from 7b23912 to cbdd44d Compare September 29, 2015 13:59

markturansky force-pushed the pv_provisioner branch from cbdd44d to 4000577 Compare September 29, 2015 14:40

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2015

jsafrane reviewed Sep 29, 2015
View reviewed changes

markturansky force-pushed the pv_provisioner branch 3 times, most recently from fdf9127 to 53aa791 Compare September 30, 2015 13:46

markturansky force-pushed the pv_provisioner branch from f93be02 to e9488ea Compare December 10, 2015 23:21

saad-ali reviewed Dec 11, 2015
View reviewed changes

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2015

markturansky reviewed Dec 11, 2015
View reviewed changes

markturansky force-pushed the pv_provisioner branch from e9488ea to 916c1e9 Compare December 11, 2015 15:27

Added PersistentVolumeController

4fc1bf1

markturansky force-pushed the pv_provisioner branch from 916c1e9 to 4fc1bf1 Compare December 11, 2015 15:33

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2015

saad-ali added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2015

j3ffml added a commit that referenced this pull request Dec 11, 2015

Merge pull request #14537 from markturansky/pv_provisioner

c103825

PersistentVolume Provisioner Controller

j3ffml merged commit c103825 into kubernetes:master Dec 11, 2015

markturansky mentioned this pull request Jan 22, 2016

integration flake: integration.TestPersistentVolumeRecycler test flaky (timed out after 5 minutes) #18050

Closed

saad-ali mentioned this pull request Jul 1, 2016

Kubernetes Volume System Redesign Proposal #18333

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PersistentVolume Provisioner Controller #14537

PersistentVolume Provisioner Controller #14537

markturansky commented Sep 25, 2015

markturansky commented Sep 25, 2015

k8s-bot commented Sep 25, 2015

k8s-bot commented Sep 25, 2015

markturansky Sep 25, 2015

k8s-github-robot commented Sep 25, 2015

pmorie Sep 25, 2015

k8s-bot commented Sep 29, 2015

k8s-bot commented Sep 29, 2015

jsafrane Sep 29, 2015

markturansky Sep 29, 2015

markturansky Sep 30, 2015

saad-ali commented Sep 30, 2015

markturansky commented Sep 30, 2015

k8s-bot commented Dec 10, 2015

markturansky commented Dec 10, 2015

k8s-bot commented Dec 11, 2015

saad-ali Dec 11, 2015

markturansky Dec 11, 2015

jsafrane commented Dec 11, 2015

pmorie commented Dec 11, 2015

markturansky Dec 11, 2015

pmorie Dec 11, 2015

saad-ali Dec 11, 2015

markturansky commented Dec 11, 2015

k8s-bot commented Dec 11, 2015

markturansky commented Dec 11, 2015

k8s-bot commented Dec 11, 2015

k8s-bot commented Dec 11, 2015

saad-ali commented Dec 11, 2015

saad-ali commented Dec 11, 2015

markturansky commented Dec 11, 2015

pmorie commented Dec 11, 2015

wattsteve commented Dec 11, 2015

PersistentVolume Provisioner Controller #14537

PersistentVolume Provisioner Controller #14537

Conversation

markturansky commented Sep 25, 2015

markturansky commented Sep 25, 2015

k8s-bot commented Sep 25, 2015

k8s-bot commented Sep 25, 2015

Choose a reason for hiding this comment

k8s-github-robot commented Sep 25, 2015

Choose a reason for hiding this comment

k8s-bot commented Sep 29, 2015

k8s-bot commented Sep 29, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saad-ali commented Sep 30, 2015

markturansky commented Sep 30, 2015

k8s-bot commented Dec 10, 2015

markturansky commented Dec 10, 2015

k8s-bot commented Dec 11, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsafrane commented Dec 11, 2015

pmorie commented Dec 11, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markturansky commented Dec 11, 2015

k8s-bot commented Dec 11, 2015

markturansky commented Dec 11, 2015

k8s-bot commented Dec 11, 2015

k8s-bot commented Dec 11, 2015

saad-ali commented Dec 11, 2015

saad-ali commented Dec 11, 2015

markturansky commented Dec 11, 2015

pmorie commented Dec 11, 2015

wattsteve commented Dec 11, 2015