Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verify gofmt #1433

Merged
merged 2 commits into from
Sep 24, 2014
Merged

Fix verify gofmt #1433

merged 2 commits into from
Sep 24, 2014

Conversation

lavalamp
Copy link
Member

Brittle version detection was brittle.

@brendandburns
Copy link
Contributor

LGTM, once travis is happy.

@brendandburns brendandburns self-assigned this Sep 24, 2014
@lavalamp
Copy link
Member Author

@brendandburns travis fixed in #1434, can we merge this?

brendandburns added a commit that referenced this pull request Sep 24, 2014
@brendandburns
Merge pull request #1433 from lavalamp/fixVerifyFmt
a981ae5 
Fix verify gofmt
@brendandburns brendandburns merged commit a981ae5 into kubernetes:master Sep 24, 2014
@brendandburns
Copy link
Contributor

merged.

@lavalamp lavalamp deleted the fixVerifyFmt branch August 26, 2015 20:02
@danehans danehans mentioned this pull request Jun 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lavalamp @brendandburns