Use Resource Consumer for tests in autoscaling.go #14275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GCE e2e build/test passed for commit c2c540f82a449a50a2f90464bf9a55ca502651b3. |
k8s-github-robot
added
the
size/M
|
Labelling this PR as size/M |
|
/cc @pmorie @jayunit100 |
|
GCE e2e build/test passed for commit 69d521d66d2281db207436bc446747f3dae9b007. |
| @@ -140,39 +142,6 @@ func CreateService(f *Framework, name string) { | |||
| Expect(err).NotTo(HaveOccurred()) | |||
| } | |||
|
|
|||
| func ConsumeCpu(f *Framework, id string, cores int) { | |||
| CreateService(f, id) | |||
There was a problem hiding this comment.
You can also remove CreateService method.
|
LGTM just a nit |
|
PTAL |
|
LGTM |
piosz
added
lgtm
|
GCE e2e build/test passed for commit a9a52a9. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit a9a52a9. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Sep 22, 2015
Auto commit by PR queue bot
This was referenced Sep 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11570
@piosz