Fix e2e testing issue #1424
Fix e2e testing issue #1424
Conversation
|
LGTM |
| if len(suffix) > 0 { | ||
| suffix = "." + suffix | ||
| } | ||
| res, err := gce.service.Instances.Get(gce.projectID, gce.zone, strings.Replace(instance, suffix, "", 1)).Do() |
There was a problem hiding this comment.
Perhaps strings.TrimRight is more appropriate.
|
LGTM aside from nits |
|
I fixed this same issue last night! I was going to send it out today. I think we can make this a little simpler by just "canonicalizing" the instance name by stripping off everything past the first dot. We do that in My change is here: https://github.com/jbeda/kubernetes/compare/hostIP-fix I also was extending the e2e test to make sure that the hostIP is created/passed through for GCE as that is one place where this shows up broken. Feel free to steal what you like. I don't mind checking in the e2e test enhancement after yours goes in. |
|
@jbeda I worked on this fix because I tried to enhance e2e test a little bit last Friday, and found it never pass for me. I will take a look at your change, and steal whatever I might need to get this in as early as possible since this PR block my another PR due to e2e test failure. Thanks! |
|
LGTM -- merging after travis says okay. |
UPSTREAM: <drop>: Bump openshift/api.
It turns out the fqdn issue is the only issue in e2e test. I ran into some weird ApiObj encode/decode issue, which is fixed by 'make clean' completely.
Fix #1385