Add config for the main gke jenkins jobs to e2e.sh #13863
Conversation
j3ffml
force-pushed
the
gke-jenkins-config
branch
from
89c93bb to
0798afc
Compare
| "Shell" | ||
| ) | ||
|
|
||
| GKE_REBOOT_SKIP_TESTS=( |
There was a problem hiding this comment.
It seems that these are almost all covered by GCE_DEFAULT_SKIP_TESTS which you already skip. Can you perhaps just delete GKE_REBOOT_SKIP_TESTS ?
There was a problem hiding this comment.
Oh, wait, I see that you don't currently skip GCE_DEFAULT_SKIP_TESTS in your reboot test. Never mind. You could potentially use --ginkgo-focus="Reboot" instead, but I don't think that's what you're trying to do here. You're trying to run all the same tests as e2e-gce, and in addition "Reboot", right? We should perhaps refactor all of this a bit to remove the duplication between GCE_DEFAULT_SKIP_TESTS and GKE_REBOOT_SKIP_TESTS, as it seems that they always need to be identical with the exception of "Reboot"?
There was a problem hiding this comment.
Right, we want to run a small, unflaky set of tests along with reboot to exercise cluster functionality post-reboot. Refactored a bit to remove duplication.
|
GCE e2e build/test passed for commit 89c93bb881be77b2a914ca7554bad1d7c38d1b4a. |
j3ffml
force-pushed
the
gke-jenkins-config
branch
from
0798afc to
231590f
Compare
|
GCE e2e build/test passed for commit 0798afcb39f06853862e01fe34e5db2936987db8. |
|
GCE e2e build/test passed for commit 231590f83ce88d356b717de474375d1151b436ed. |
| @@ -496,6 +599,19 @@ ARTIFACTS=${WORKSPACE}/_artifacts | |||
| mkdir -p ${ARTIFACTS} | |||
| export E2E_REPORT_DIR=${ARTIFACTS} | |||
|
|
|||
| ### Pre Set Up ### | |||
There was a problem hiding this comment.
What's all this stuff for? Please add a comment explaining why this is required.
|
Thanks @jlowdermilk . One minor nit about a missing comment, then LGTM. |
j3ffml
force-pushed
the
gke-jenkins-config
branch
from
231590f to
0caac10
Compare
j3ffml
force-pushed
the
gke-jenkins-config
branch
from
0caac10 to
7229096
Compare
|
LGTM. Thanks @jlowdermilk |
ghost
added
the
lgtm
|
GCE e2e build/test passed for commit 0caac10ae29ec8f4414ef2684b67eb4472362fd5. |
|
GCE e2e build/test passed for commit 7229096. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 7229096. |
|
Automatic merge from SubmitQueue |
Auto commit by PR queue bot
…13863-upstream-release-1.0 Add config for the main gke-jenkins jobs to e2e.sh
Verified working. The gke-jenkins below are currently running from this script.
cc @ixdy, @quinton-hoole