bump ci go version to 1.5.1 #13838

mikedanese · 2015-09-10T22:15:25Z

[TESTING] redo of #12967, thanks @mvdan for fixing all the tests.

k8s-bot · 2015-09-10T22:40:36Z

GCE e2e build/test passed for commit 394d474e6bf14cce926762b57b899e8dc3f54505.

mvdan · 2015-09-10T22:43:17Z

+1

FWIW you can make Travis run on 1.4 as well as 1.5.1 too.

mvdan · 2015-09-10T22:47:15Z

Still getting 500's on shippable.

lavalamp · 2015-09-11T21:58:56Z

I restarted shippable-- is it fixed today?

mvdan · 2015-09-11T22:00:44Z

@lavalamp still a 500:

{"id":1004,"message":"GET failed for 54c71b655ab6cc135289dd2d","methodName":"caller:public|projects|getById:54c71b655ab6cc135289dd2d|_getById","link":500}

mikedanese · 2015-09-11T23:03:54Z

Well it's green. 👍. I'm going to restart it a couple times.

k8s-bot · 2015-09-12T21:50:02Z

GCE e2e build/test failed for commit 885738a2a172814c0ff23d69a32ab73f06522fb4.

mikedanese · 2015-09-12T21:52:29Z

4 races

==================
WARNING: DATA RACE
Write by goroutine 12:
  k8s.io/kubernetes/plugin/pkg/admission/namespace/lifecycle.TestAdmission()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/plugin/pkg/admission/namespace/lifecycle/admission_test.go:81 +0x194d
  testing.tRunner()
      /tmp/workdir/go/src/testing/testing.go:456 +0xdc

Previous read by goroutine 13:
  k8s.io/kubernetes/plugin/pkg/admission/namespace/lifecycle.TestAdmission.func2()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/plugin/pkg/admission/namespace/lifecycle/admission_test.go:55 +0xed
  k8s.io/kubernetes/pkg/client/unversioned/testclient.(*SimpleReactor).React()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/unversioned/testclient/fixture.go:260 +0x7c
  k8s.io/kubernetes/pkg/client/unversioned/testclient.(*Fake).Invokes()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/unversioned/testclient/testclient.go:112 +0x36f
  k8s.io/kubernetes/pkg/client/unversioned/testclient.(*FakeNamespaces).List()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/unversioned/testclient/fake_namespaces.go:42 +0x255
  k8s.io/kubernetes/plugin/pkg/admission/namespace/lifecycle.NewLifecycle.func1()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/plugin/pkg/admission/namespace/lifecycle/admission.go:108 +0x213
  k8s.io/kubernetes/pkg/client/cache.(*ListWatch).List()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/cache/listwatch.go:68 +0x58
  k8s.io/kubernetes/pkg/client/cache.(*Reflector).ListAndWatch()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/cache/reflector.go:179 +0xe9
  k8s.io/kubernetes/pkg/client/cache.(*Reflector).Run.func1()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/cache/reflector.go:138 +0x53
  k8s.io/kubernetes/pkg/util.Until.func1()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/util.go:115 +0x58
  k8s.io/kubernetes/pkg/util.Until()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/util.go:116 +0x65

Goroutine 12 (running) created at:
  testing.RunTests()
      /tmp/workdir/go/src/testing/testing.go:561 +0xaa3
  testing.(*M).Run()
      /tmp/workdir/go/src/testing/testing.go:494 +0xe4
  main.main()
      k8s.io/kubernetes/plugin/pkg/admission/namespace/lifecycle/_test/_testmain.go:54 +0x20f

Goroutine 13 (running) created at:
  k8s.io/kubernetes/pkg/client/cache.(*Reflector).Run()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/cache/reflector.go:138 +0xe4
  k8s.io/kubernetes/plugin/pkg/admission/namespace/lifecycle.NewLifecycle()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/plugin/pkg/admission/namespace/lifecycle/admission.go:118 +0x5db
  k8s.io/kubernetes/plugin/pkg/admission/namespace/lifecycle.TestAdmission()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/plugin/pkg/admission/namespace/lifecycle/admission_test.go:58 +0xed3
  testing.tRunner()
      /tmp/workdir/go/src/testing/testing.go:456 +0xdc
==================
PASS
Found 1 data race(s)
FAIL    k8s.io/kubernetes/plugin/pkg/admission/namespace/lifecycle  1.048s
ok      k8s.io/kubernetes/plugin/pkg/admission/resourcequota    1.053s
ok      k8s.io/kubernetes/plugin/pkg/admission/securitycontext/scdeny   1.041s
ok      k8s.io/kubernetes/plugin/pkg/admission/serviceaccount   2.453s
ok      k8s.io/kubernetes/plugin/pkg/auth/authenticator/password/allow  1.021s
ok      k8s.io/kubernetes/plugin/pkg/auth/authenticator/password/passwordfile   1.026s
ok      k8s.io/kubernetes/plugin/pkg/auth/authenticator/request/basicauth   1.020s
ok      k8s.io/kubernetes/plugin/pkg/auth/authenticator/request/keystone    1.022s
ok      k8s.io/kubernetes/plugin/pkg/auth/authenticator/request/union   1.045s
ok      k8s.io/kubernetes/plugin/pkg/auth/authenticator/request/x509    1.037s
I0912 21:41:00.844912   16431 oidc.go:71] No x509 certificates provided, will use host's root CA set
E0912 21:41:00.879802   16431 oidc.go:99] Failed to fetch provider config, trying again in 1s: Get https://foo/bar/.well-known/openid-configuration: dial tcp: lookup foo on 8.8.8.8:53: no such host
E0912 21:41:01.898719   16431 oidc.go:99] Failed to fetch provider config, trying again in 1s: Get https://foo/bar/.well-known/openid-configuration: dial tcp: lookup foo on 8.8.8.8:53: no such host
E0912 21:41:02.918327   16431 oidc.go:99] Failed to fetch provider config, trying again in 1s: Get https://foo/bar/.well-known/openid-configuration: dial tcp: lookup foo on 8.8.8.8:53: no such host
I0912 21:41:05.624025   16431 oidc.go:103] Fetched provider config from https://127.0.0.1:51574: oidc.ProviderConfig{Issuer:"https://127.0.0.1:51574", AuthEndpoint:"", TokenEndpoint:"", KeysEndpoint:"", ResponseTypesSupported:[]string(nil), GrantTypesSupported:[]string(nil), SubjectTypesSupported:[]string(nil), IDTokenAlgValuesSupported:[]string(nil), TokenEndpointAuthMethodsSupported:[]string(nil), ExpiresAt:time.Time{sec:0, nsec:0, loc:(*time.Location)(nil)}}
E0912 21:41:08.703518   16431 oidc.go:99] Failed to fetch provider config, trying again in 1s: Get https://127.0.0.1:32928/.well-known/openid-configuration: x509: certificate signed by unknown authority
E0912 21:41:09.711591   16431 oidc.go:99] Failed to fetch provider config, trying again in 1s: Get https://127.0.0.1:32928/.well-known/openid-configuration: x509: certificate signed by unknown authority
E0912 21:41:10.718088   16431 oidc.go:99] Failed to fetch provider config, trying again in 1s: Get https://127.0.0.1:32928/.well-known/openid-configuration: x509: certificate signed by unknown authority
I0912 21:41:12.447937   16431 oidc.go:103] Fetched provider config from https://127.0.0.1:35575: oidc.ProviderConfig{Issuer:"https://127.0.0.1:35575", AuthEndpoint:"", TokenEndpoint:"", KeysEndpoint:"https://127.0.0.1:35575/keys", ResponseTypesSupported:[]string(nil), GrantTypesSupported:[]string(nil), SubjectTypesSupported:[]string(nil), IDTokenAlgValuesSupported:[]string(nil), TokenEndpointAuthMethodsSupported:[]string(nil), ExpiresAt:time.Time{sec:0, nsec:0, loc:(*time.Location)(nil)}}
I0912 21:41:12.572259   16431 oidc.go:103] Fetched provider config from https://127.0.0.1:35575: oidc.ProviderConfig{Issuer:"https://127.0.0.1:35575", AuthEndpoint:"", TokenEndpoint:"", KeysEndpoint:"https://127.0.0.1:35575/keys", ResponseTypesSupported:[]string(nil), GrantTypesSupported:[]string(nil), SubjectTypesSupported:[]string(nil), IDTokenAlgValuesSupported:[]string(nil), TokenEndpointAuthMethodsSupported:[]string(nil), ExpiresAt:time.Time{sec:0, nsec:0, loc:(*time.Location)(nil)}}
I0912 21:41:12.662753   16431 oidc.go:103] Fetched provider config from https://127.0.0.1:35575: oidc.ProviderConfig{Issuer:"https://127.0.0.1:35575", AuthEndpoint:"", TokenEndpoint:"", KeysEndpoint:"https://127.0.0.1:35575/keys", ResponseTypesSupported:[]string(nil), GrantTypesSupported:[]string(nil), SubjectTypesSupported:[]string(nil), IDTokenAlgValuesSupported:[]string(nil), TokenEndpointAuthMethodsSupported:[]string(nil), ExpiresAt:time.Time{sec:0, nsec:0, loc:(*time.Location)(nil)}}
I0912 21:41:12.751161   16431 oidc.go:103] Fetched provider config from https://127.0.0.1:35575: oidc.ProviderConfig{Issuer:"https://127.0.0.1:35575", AuthEndpoint:"", TokenEndpoint:"", KeysEndpoint:"https://127.0.0.1:35575/keys", ResponseTypesSupported:[]string(nil), GrantTypesSupported:[]string(nil), SubjectTypesSupported:[]string(nil), IDTokenAlgValuesSupported:[]string(nil), TokenEndpointAuthMethodsSupported:[]string(nil), ExpiresAt:time.Time{sec:0, nsec:0, loc:(*time.Location)(nil)}}
==================
WARNING: DATA RACE
Read by goroutine 65:
  github.com/coreos/go-oidc/oidc.(*Client).VerifyJWT()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/client.go:285 +0x261
  k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc.(*OIDCAuthenticator).AuthenticateToken()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc/oidc.go:136 +0x157
  k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc.TestOIDCAuthentication()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc/oidc_test.go:378 +0x1654
  testing.tRunner()
      /tmp/workdir/go/src/testing/testing.go:456 +0xdc

Previous write by goroutine 102:
  github.com/coreos/go-oidc/oidc.(*providerConfigRepo).Set()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/client.go:194 +0x86
  github.com/coreos/go-oidc/oidc.(*ProviderConfigSyncer).sync()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/provider.go:111 +0x15a
  github.com/coreos/go-oidc/oidc.(*ProviderConfigSyncer).(github.com/coreos/go-oidc/oidc.sync)-fm()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/provider.go:95 +0x3b
  github.com/coreos/go-oidc/oidc.(*pcsStepNext).step()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/provider.go:136 +0x7c
  github.com/coreos/go-oidc/oidc.(*ProviderConfigSyncer).Run.func1()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/provider.go:95 +0x1c9

Goroutine 65 (running) created at:
  testing.RunTests()
      /tmp/workdir/go/src/testing/testing.go:561 +0xaa3
  testing.(*M).Run()
      /tmp/workdir/go/src/testing/testing.go:494 +0xe4
  main.main()
      k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc/_test/_testmain.go:60 +0x20f

Goroutine 102 (running) created at:
  github.com/coreos/go-oidc/oidc.(*ProviderConfigSyncer).Run()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/provider.go:100 +0x122
  github.com/coreos/go-oidc/oidc.(*Client).SyncProviderConfig()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/client.go:158 +0x391
  k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc.New()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc/oidc.go:123 +0xd7f
  k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc.TestOIDCAuthentication()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc/oidc_test.go:373 +0x14f6
  testing.tRunner()
      /tmp/workdir/go/src/testing/testing.go:456 +0xdc
==================
==================
WARNING: DATA RACE
Read by goroutine 65:
  github.com/coreos/go-oidc/oidc.(*Client).maybeSyncKeys()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/client.go:181 +0x18c
  github.com/coreos/go-oidc/oidc.(*Client).(github.com/coreos/go-oidc/oidc.maybeSyncKeys)-fm()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/client.go:285 +0x3b
  github.com/coreos/go-oidc/oidc.(*JWTVerifier).Verify()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/verification.go:150 +0x439
  github.com/coreos/go-oidc/oidc.(*Client).VerifyJWT()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/client.go:287 +0x4c4
  k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc.(*OIDCAuthenticator).AuthenticateToken()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc/oidc.go:136 +0x157
  k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc.TestOIDCAuthentication()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc/oidc_test.go:378 +0x1654
  testing.tRunner()
      /tmp/workdir/go/src/testing/testing.go:456 +0xdc

Previous write by goroutine 102:
  github.com/coreos/go-oidc/oidc.(*providerConfigRepo).Set()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/client.go:194 +0x86
  github.com/coreos/go-oidc/oidc.(*ProviderConfigSyncer).sync()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/provider.go:111 +0x15a
  github.com/coreos/go-oidc/oidc.(*ProviderConfigSyncer).(github.com/coreos/go-oidc/oidc.sync)-fm()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/provider.go:95 +0x3b
  github.com/coreos/go-oidc/oidc.(*pcsStepNext).step()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/provider.go:136 +0x7c
  github.com/coreos/go-oidc/oidc.(*ProviderConfigSyncer).Run.func1()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/provider.go:95 +0x1c9

Goroutine 65 (running) created at:
  testing.RunTests()
      /tmp/workdir/go/src/testing/testing.go:561 +0xaa3
  testing.(*M).Run()
      /tmp/workdir/go/src/testing/testing.go:494 +0xe4
  main.main()
      k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc/_test/_testmain.go:60 +0x20f

Goroutine 102 (running) created at:
  github.com/coreos/go-oidc/oidc.(*ProviderConfigSyncer).Run()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/provider.go:100 +0x122
  github.com/coreos/go-oidc/oidc.(*Client).SyncProviderConfig()
      /root/workspace/src/k8s.io/kubernetes/Godeps/_workspace/src/github.com/coreos/go-oidc/oidc/client.go:158 +0x391
  k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc.New()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc/oidc.go:123 +0xd7f
  k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc.TestOIDCAuthentication()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc/oidc_test.go:373 +0x14f6
  testing.tRunner()
      /tmp/workdir/go/src/testing/testing.go:456 +0xdc
==================
I0912 21:41:12.846682   16431 oidc.go:103] Fetched provider config from https://127.0.0.1:35575: oidc.ProviderConfig{Issuer:"https://127.0.0.1:35575", AuthEndpoint:"", TokenEndpoint:"", KeysEndpoint:"https://127.0.0.1:35575/keys", ResponseTypesSupported:[]string(nil), GrantTypesSupported:[]string(nil), SubjectTypesSupported:[]string(nil), IDTokenAlgValuesSupported:[]string(nil), TokenEndpointAuthMethodsSupported:[]string(nil), ExpiresAt:time.Time{sec:0, nsec:0, loc:(*time.Location)(nil)}}
I0912 21:41:12.948092   16431 oidc.go:103] Fetched provider config from https://127.0.0.1:35575: oidc.ProviderConfig{Issuer:"https://127.0.0.1:35575", AuthEndpoint:"", TokenEndpoint:"", KeysEndpoint:"https://127.0.0.1:35575/keys", ResponseTypesSupported:[]string(nil), GrantTypesSupported:[]string(nil), SubjectTypesSupported:[]string(nil), IDTokenAlgValuesSupported:[]string(nil), TokenEndpointAuthMethodsSupported:[]string(nil), ExpiresAt:time.Time{sec:0, nsec:0, loc:(*time.Location)(nil)}}
PASS
Found 2 data race(s)
FAIL    k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/oidc  13.228s
ok      k8s.io/kubernetes/plugin/pkg/auth/authenticator/token/tokenfile 1.025s
ok      k8s.io/kubernetes/plugin/pkg/scheduler  1.062s
ok      k8s.io/kubernetes/plugin/pkg/scheduler/algorithm    1.035s
ok      k8s.io/kubernetes/plugin/pkg/scheduler/algorithm/predicates 1.048s
ok      k8s.io/kubernetes/plugin/pkg/scheduler/algorithm/priorities 1.053s
ok      k8s.io/kubernetes/plugin/pkg/scheduler/algorithmprovider    1.050s
ok      k8s.io/kubernetes/plugin/pkg/scheduler/algorithmprovider/defaults   1.052s
ok      k8s.io/kubernetes/plugin/pkg/scheduler/api/validation   1.031s
==================
WARNING: DATA RACE
Write by goroutine 25:
  sync.raceWrite()
      /tmp/workdir/go/src/sync/race.go:41 +0x2e
  sync.(*WaitGroup).Wait()
      /tmp/workdir/go/src/sync/waitgroup.go:124 +0xf9
  net/http/httptest.(*Server).Close()
      /tmp/workdir/go/src/net/http/httptest/server.go:168 +0x80
  k8s.io/kubernetes/plugin/pkg/scheduler/factory.TestCreateFromEmptyConfig()
      /root/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/plugin/pkg/scheduler/factory/factory_test.go:116 +0x59e
  testing.tRunner()
      /tmp/workdir/go/src/testing/testing.go:456 +0xdc

Previous read by goroutine 36:
  sync.raceRead()
      /tmp/workdir/go/src/sync/race.go:37 +0x2e
  sync.(*WaitGroup).Add()
      /tmp/workdir/go/src/sync/waitgroup.go:66 +0xfa
  net/http/httptest.(*waitGroupHandler).ServeHTTP()
      /tmp/workdir/go/src/net/http/httptest/server.go:198 +0x5c
  net/http.serverHandler.ServeHTTP()
      /tmp/workdir/go/src/net/http/server.go:1862 +0x206
  net/http.(*conn).serve()
      /tmp/workdir/go/src/net/http/server.go:1361 +0x117c

Goroutine 25 (running) created at:
  testing.RunTests()
      /tmp/workdir/go/src/testing/testing.go:561 +0xaa3
  testing.(*M).Run()
      /tmp/workdir/go/src/testing/testing.go:494 +0xe4
  main.main()
      k8s.io/kubernetes/plugin/pkg/scheduler/factory/_test/_testmain.go:68 +0x20f

Goroutine 36 (running) created at:
  net/http.(*Server).Serve()
      /tmp/workdir/go/src/net/http/server.go:1910 +0x464
==================
E0912 21:41:29.305198   17014 factory.go:270] Error scheduling bar foo: ; retrying
PASS
Found 1 data race(s)
FAIL    k8s.io/kubernetes/plugin/pkg/scheduler/factory  1.095s

mikedanese · 2015-09-12T21:59:54Z

One data race in testclient, two in github.com/coreos/go-oidc/oidc, and one in net/http and scheduler

mvdan · 2015-09-12T22:01:41Z

I can have a quick look later today.

k8s-github-robot · 2015-09-13T01:17:07Z

Labelling this PR as size/S

ghost · 2015-09-17T19:28:01Z

Jenkins e2e failure was a flaky test.

@k8s-bot test this again please

mikedanese · 2015-09-17T19:29:36Z

However shippable failure's are not flakes :(

k8s-bot · 2015-09-17T19:50:12Z

GCE e2e build/test failed for commit 885738a2a172814c0ff23d69a32ab73f06522fb4.

mvdan · 2015-09-21T02:01:45Z

The plugin/pkg/scheduler/factory one is a known bug in Go: golang/go#12262

mvdan · 2015-09-21T02:11:28Z

The oidc one looks like a bug in go-oidc... need to dig more.

wojtek-t · 2015-12-10T09:23:05Z

I've also sent out #18499 out for review which should fix one more data-race.

I think that for all problems in this PR, there are currently PRs under review fixing them.

wojtek-t · 2015-12-14T12:59:29Z

So just to summarize:

[under review] pkg/client/cache - should be fixed by Fix data-race in reflector test in Go 1.5.1 #18499
[waiting for merge] pkg/kubelet/prober - should be fixed by Fix data race in prober test #18449
[in progress] pkg/registry/* - should be store: fix data race when modify event in watchHub. etcd-io/etcd#3972, but it needs to be patched to etcd 2.2 and the our dependency needs to be updated
pkg/storage - seems to be the same as pkg/registry/*
[under review] pkg/auth/authenticator/token/oidc - should be fixed by Godeps: bump go-oidc to fix the race in tests. #18478

wojtek-t · 2015-12-15T10:00:13Z

Restarting to see where we are now.

@k8s-bot unit test this please

wojtek-t · 2015-12-15T10:47:54Z

OK - it's much better now. The failing tests are:

k8s.io/kubernetes/pkg/kubelet/prober [Fix data race in prober test #18449 waiting for merge]
k8s.io/kubernetes/pkg/registry/generic/etcd
k8s.io/kubernetes/pkg/storage
k8s.io/kubernetes/pkg/storage/etcd

The last 3 failures are exactly the same - I opened #18701 for it.

wojtek-t · 2015-12-15T13:57:51Z

#18449 has just been merged - rerunning to check if the issue is fixed.

@k8s-bot unit test this please

wojtek-t · 2015-12-15T14:34:02Z

hmm - #18449 fixed one problem, but there is one more there.

So to summarize - there are two issues left:

wojtek-t · 2015-12-18T13:20:38Z

#18635 has just been merged (when running locally, it fixed one of the issue).
Checking where we are

@k8s-bot unit test this please

wojtek-t · 2015-12-18T14:00:04Z

It seems that we are now only waiting for these PRs to be merged:

Both are already LGTM-ed, so we should be ready to go with this PR soon.

timothysc · 2015-12-18T14:53:48Z

@wojtek-t awesome! I took a look at some gc profiles from 1.5 vs. 1.4 and it's night and day.

/cc @eparis .

wojtek-t · 2015-12-18T15:16:40Z

@wojtek-t awesome! I took a look at some gc profiles from 1.5 vs. 1.4 and it's night and day.

Yes - I've seen the same.

I've just manually merge those 2 PRs. Rerunning tests to check if we're really done.

@k8s-bot test this please

k8s-bot · 2015-12-18T15:53:37Z

GCE e2e test build/test passed for commit c2753d7.

wojtek-t · 2015-12-18T15:54:03Z

We are all green - yay!

wojtek-t · 2015-12-18T15:55:11Z

I vote for applying "LGTM" label on this PR and merging it.

@thockin @brendandburns @mikedanese - any objections?

eparis · 2015-12-18T17:01:29Z

I really want to click the button, but since I'm out in an hour, that's probably not nice of me. We have clean tests, I say GO.

wojtek-t · 2015-12-18T17:34:47Z

After discussing with @thockin and @brendandburns we are going to merge it soon.

Applying "LGTM" label (we will revert in case of significant issues).

k8s-github-robot · 2015-12-18T18:33:07Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2015-12-18T19:04:54Z

GCE e2e test build/test passed for commit c2753d7.

k8s-github-robot · 2015-12-18T19:09:15Z

Automatic merge from submit-queue

Auto commit by PR queue bot

pmorie · 2015-12-20T17:22:53Z

Related #18907; codecgen appears to behave differently under go 1.4 and 1.5; Travis runs 1.5 and fails diffs generated by 1.4.

@mikedanese @wojtek-t @eparis @ncdc

wojtek-t · 2015-12-20T20:24:10Z

yeah - I'm afraid we have a bunch of problems with unit test too
I think that if we won't fix them today/tomorrow, we should probably revert this change...

pmorie · 2016-01-06T14:39:50Z

I'm no longer certain that the problem is the golan version; I've had a couple situations where I did a hack/update-all.sh and then verify-all.sh failed on codecgen. When I ran hack/update-codecgen manually after that, and reverified, it worked. Will open a new issue to track that.

googlebot added the cla: yes label Sep 10, 2015

mikedanese changed the title ~~bump ci go version to 1.5~~ bump ci go version to 1.5.1 Sep 10, 2015

mikedanese force-pushed the go1.5 branch from 7e9c43b to 394d474 Compare September 10, 2015 22:16

mikedanese assigned lavalamp Sep 10, 2015

mikedanese force-pushed the go1.5 branch from 9c1cbe0 to 885738a Compare September 12, 2015 21:20

k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 13, 2015

This was referenced Sep 17, 2015

Add support for Go 1.5 kubernetes-retired/heapster#495

Closed

Fix race in lifecycle admission test #14246

Merged

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2015

mvdan mentioned this pull request Sep 30, 2015

Up to golang 1.5 #14873

Closed

mikedanese closed this Sep 30, 2015

mikedanese force-pushed the go1.5 branch from 885738a to bd8ee1c Compare September 30, 2015 21:37

mikedanese reopened this Sep 30, 2015

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2015

timothysc mentioned this pull request Dec 14, 2015

Update etcd godep to fix golang 1.5.1 data race #18684

Merged

wojtek-t assigned wojtek-t and unassigned thockin Dec 15, 2015

wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2015

k8s-github-robot pushed a commit that referenced this pull request Dec 18, 2015

Merge pull request #13838 from mikedanese/go1.5

7eda961

Auto commit by PR queue bot

k8s-github-robot merged commit 7eda961 into kubernetes:master Dec 18, 2015

mikedanese deleted the go1.5 branch December 18, 2015 19:18

timothysc mentioned this pull request Dec 18, 2015

TestWatchEtcdError fairly consistently timing out #18914

Closed

ixdy mentioned this pull request Dec 18, 2015

data race in k8s.io/kubernetes/pkg/storage/etcd #18913

Closed

bump ci go version to 1.5.1 #13838

bump ci go version to 1.5.1 #13838

Conversation

mikedanese commented Sep 10, 2015

k8s-bot commented Sep 10, 2015

mvdan commented Sep 10, 2015

mvdan commented Sep 10, 2015

lavalamp commented Sep 11, 2015

mvdan commented Sep 11, 2015

mikedanese commented Sep 11, 2015

k8s-bot commented Sep 12, 2015

mikedanese commented Sep 12, 2015

mikedanese commented Sep 12, 2015

mvdan commented Sep 12, 2015

k8s-github-robot commented Sep 13, 2015

ghost commented Sep 17, 2015

mikedanese commented Sep 17, 2015

k8s-bot commented Sep 17, 2015

mvdan commented Sep 21, 2015

mvdan commented Sep 21, 2015

wojtek-t commented Dec 10, 2015

wojtek-t commented Dec 14, 2015

wojtek-t commented Dec 15, 2015

wojtek-t commented Dec 15, 2015

wojtek-t commented Dec 15, 2015

wojtek-t commented Dec 15, 2015

wojtek-t commented Dec 18, 2015

wojtek-t commented Dec 18, 2015

timothysc commented Dec 18, 2015

wojtek-t commented Dec 18, 2015

k8s-bot commented Dec 18, 2015

wojtek-t commented Dec 18, 2015

wojtek-t commented Dec 18, 2015

eparis commented Dec 18, 2015

wojtek-t commented Dec 18, 2015

k8s-github-robot commented Dec 18, 2015

k8s-bot commented Dec 18, 2015

k8s-github-robot commented Dec 18, 2015

pmorie commented Dec 20, 2015

wojtek-t commented Dec 20, 2015

pmorie commented Jan 6, 2016