Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support extended pod logging options #13780

Merged
merged 2 commits into from
Sep 22, 2015
Merged

Support extended pod logging options #13780

merged 2 commits into from
Sep 22, 2015

Conversation

smarterclayton
Copy link
Contributor

Increase the supported controls on pod logging. Add validation to pod log
options. Ensure the Kubelet is using a consistent, structured way to
process pod log arguments.

?sinceTime=<RFC3339>         # RFC3339 timestamp
?sinceSeconds=<seconds>      # duration in seconds backwards in time
?timestamps=<bool>           # begin each line with an RFC3339 or RFC3339Nano timestamp
?tail=<number>               # return the last N lines of output
?limitBytes=<number>         # return no more than this number of bytes

Fixes #12447

@smarterclayton smarterclayton changed the title Support extended pod logging options WIP - Support extended pod logging options Sep 10, 2015
@smarterclayton
Copy link
Contributor Author

@kubernetes/kube-api for api review (on proposal #12447) @kubernetes/goog-cluster for logging, and @kubernetes/rh-cluster-infra

@k8s-bot
Copy link

k8s-bot commented Sep 10, 2015

GCE e2e build/test passed for commit cfdf793aef23c99a010081fae2a37c94182c1031.

@k8s-bot
Copy link

k8s-bot commented Sep 10, 2015

GCE e2e build/test passed for commit 7073f328bff5bb7d2ee4cf7dc83e22db85a1da51.

@k8s-bot
Copy link

k8s-bot commented Sep 10, 2015

GCE e2e build/test passed for commit cfd8210c6420300f054b3d7b0f00d57f44520155.

@smarterclayton smarterclayton force-pushed the pod_logs branch 2 times, most recently from bdf3c79 to c5a4ae2 Compare September 10, 2015 19:52
@smarterclayton smarterclayton changed the title WIP - Support extended pod logging options Support extended pod logging options Sep 10, 2015
@smarterclayton
Copy link
Contributor Author

This is ready for review, added to kubectl, e2e test, and additional validation and tests along the way.

@k8s-bot
Copy link

k8s-bot commented Sep 10, 2015

GCE e2e build/test failed for commit bdf3c79bbba79c4c8f48ff30c3c78ee6a01b515a.

@k8s-bot
Copy link

k8s-bot commented Sep 10, 2015

GCE e2e build/test failed for commit c5a4ae2ac3dc90f3345df273b0b8d16766bd62cd.

@ironcladlou
Copy link
Contributor

You might want a test for the conversion change... here's one I made: master...ironcladlou:convert-mismatched-ptr-types

@smarterclayton
Copy link
Contributor Author

Thanks for the test

@k8s-bot
Copy link

k8s-bot commented Sep 11, 2015

GCE e2e build/test failed for commit dda62706ffcd6af1544a533cdfd976a2e007077e.

@smarterclayton smarterclayton force-pushed the pod_logs branch 2 times, most recently from 4d673be to 385ea56 Compare September 11, 2015 04:39
@k8s-bot
Copy link

k8s-bot commented Sep 11, 2015

GCE e2e build/test failed for commit 4d673beced4e56b11d7c2bbb88f87875fdd7aab1.

@k8s-bot
Copy link

k8s-bot commented Sep 11, 2015

GCE e2e build/test failed for commit 385ea568f677c1f564cd436cc7396a2343ca3362.

@ironcladlou ironcladlou mentioned this pull request Sep 11, 2015
Merged
@k8s-bot
Copy link

k8s-bot commented Sep 21, 2015

GCE e2e build/test passed for commit 881e750d07afa19633098e42607081ca8ba9fbb7.

@k8s-bot
Copy link

k8s-bot commented Sep 21, 2015

GCE e2e build/test passed for commit 881e750d07afa19633098e42607081ca8ba9fbb7.

@smarterclayton
Allow []string to be converted to *int64
a02bcef 
Not something we hit before
@k8s-bot
Copy link

k8s-bot commented Sep 21, 2015

GCE e2e build/test failed for commit 6d26cf830fbdf1c184a52c4b1ca2e237290014bb.

@smarterclayton
Copy link
Contributor Author

Shippable is a flake (datarace on etcd), e2e is a flake. Rerunning e2e

@smarterclayton
Copy link
Contributor Author

ok to test

@k8s-bot
Copy link

k8s-bot commented Sep 21, 2015

GCE e2e build/test failed for commit 6d26cf830fbdf1c184a52c4b1ca2e237290014bb.

@smarterclayton
Support extended pod logging options
c2e90cd 
Increase the supported controls on pod logging. Add validaiton to pod
log options. Ensure the Kubelet is using a consistent, structured way to
process pod log arguments.

Add ?sinceSeconds=<durationInSeconds>, &sinceTime=<RFC3339>, ?timestamps=<bool>,
?tailLines=<number>, and ?limitBytes=<number>
@k8s-bot
Copy link

k8s-bot commented Sep 21, 2015

GCE e2e build/test passed for commit c2e90cd.

@derekwaynecarr derekwaynecarr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2015
@smarterclayton
Copy link
Contributor Author

Shippable was a flake, can someone reapply the LGTM?

@derekwaynecarr
Copy link
Member

@smarterclayton - did

@derekwaynecarr
Copy link
Member

Also kicked shippable

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 22, 2015

GCE e2e build/test passed for commit c2e90cd.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Sep 22, 2015
Merge pull request #13780 from smarterclayton/pod_logs
c96c76b 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit c96c76b into kubernetes:master Sep 22, 2015
@erictune erictune added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 22, 2015
@0xmichalis 0xmichalis mentioned this pull request Jan 20, 2016
Closed
@mnaughto mnaughto mentioned this pull request Jan 20, 2016
Closed
@ikehz ikehz mentioned this pull request Jan 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0xmichalis 0xmichalis

Labels
area/api Indicates an issue on api area. area/apiserver area/kubelet area/kubelet-api area/logging area/usability lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.