Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed kube-proxy birthCry event as it seemed to start too early #13669

Merged

Conversation

aveshagarwal
Copy link
Member

Fixed kube-proxy birthCry event as it seemed to start too early and
had a possibility to not start successfully after the event was already
posted.

had a possibility to not start successfully after the event was already
posted.
@k8s-bot
Copy link

k8s-bot commented Sep 8, 2015

GCE e2e build/test passed for commit da883148748a2b9be11176dbdd054b405ec8fdf6.

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 8, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-bot
Copy link

k8s-bot commented Sep 8, 2015

GCE e2e build/test failed for commit 599100d.

@ncdc
Copy link
Member

ncdc commented Sep 8, 2015

@kubernetes/rh-cluster-infra

@caesarxuchao caesarxuchao added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Sep 8, 2015
@pmorie
Copy link
Member

pmorie commented Sep 8, 2015

LGTM

1 similar comment
@lavalamp
Copy link
Member

lavalamp commented Sep 8, 2015

LGTM

@lavalamp lavalamp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2015
@lavalamp
Copy link
Member

lavalamp commented Sep 8, 2015

@k8s-bot test this

@k8s-bot
Copy link

k8s-bot commented Sep 8, 2015

GCE e2e build/test passed for commit 599100d.

@k8s-bot
Copy link

k8s-bot commented Sep 8, 2015

GCE e2e build/test passed for commit 599100d.

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 9, 2015

GCE e2e build/test passed for commit 599100d.

@k8s-github-robot
Copy link

Automatic merge from SubmitQueue

k8s-github-robot pushed a commit that referenced this pull request Sep 9, 2015
@k8s-github-robot k8s-github-robot merged commit 5a01a76 into kubernetes:master Sep 9, 2015
@aveshagarwal aveshagarwal deleted the proxy-birthcry-fix branch September 14, 2015 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants