Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal Pod Autoscaling e2e tests #13640

Merged
merged 1 commit into from
Sep 8, 2015
Merged

Horizontal Pod Autoscaling e2e tests #13640

merged 1 commit into from
Sep 8, 2015

Conversation

socaa
Copy link

@socaa socaa commented Sep 7, 2015

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 7, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-bot
Copy link

k8s-bot commented Sep 7, 2015

GCE e2e build/test failed for commit c99b1f51939b25876eeb62f364dc51d050b00627.

@socaa socaa force-pushed the horizontal-pod-autoscaling-test branch from c99b1f5 to e0f7a40 Compare September 7, 2015 11:25
@k8s-bot
Copy link

k8s-bot commented Sep 7, 2015

GCE e2e build/test failed for commit e0f7a404533b669f7c9725d9785b3f50c23c0625.

jszczepkowski
jszczepkowski reviewed Sep 7, 2015
View reviewed changes
test/e2e/autoscaling_utils.go
}

func (rc *ConsumingRC) ReplicasEqual(desiredReplicas int) {
Logf("REPLICAS: %d", rc.GetReplicas())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this log more readable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@socaa socaa force-pushed the horizontal-pod-autoscaling-test branch from e0f7a40 to 9070391 Compare September 8, 2015 09:10
@socaa
Copy link
Author

socaa commented Sep 8, 2015

PTAL

@piosz
@jszczepkowski

@socaa socaa force-pushed the horizontal-pod-autoscaling-test branch from 9070391 to 06ca49c Compare September 8, 2015 09:21
@k8s-bot
Copy link

k8s-bot commented Sep 8, 2015

GCE e2e build/test passed for commit 907039119e7cabdfb18b55686903df9b95a3e5bd.

@k8s-bot
Copy link

k8s-bot commented Sep 8, 2015

GCE e2e build/test failed for commit 06ca49c9bd97b30c29d5ed4ba9ab2e536c22ebd5.

jszczepkowski
jszczepkowski reviewed Sep 8, 2015
View reviewed changes
test/e2e/autoscaling_utils.go
return replicationController.Status.Replicas
}

func (rc *ResourceConsumer) ReplicasEqual(desiredReplicas int) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call this WaitForReplicas

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jszczepkowski
Copy link
Contributor

The tests seems to be broken:

hack/verify-boilerplate.sh
Boilerplate header is wrong for: /home/travis/gopath/src/github.com/kubernetes/kubernetes/test/e2e/horizontal_pod_autoscaling.go

@socaa socaa force-pushed the horizontal-pod-autoscaling-test branch from 06ca49c to 3ddbb7d Compare September 8, 2015 11:29
@socaa
Copy link
Author

socaa commented Sep 8, 2015

PTAL

@piosz
@jszczepkowski

@k8s-bot
Copy link

k8s-bot commented Sep 8, 2015

GCE e2e build/test passed for commit 3ddbb7d.

@jszczepkowski
Copy link
Contributor

LGTM
Great thanks!

@jszczepkowski jszczepkowski added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Sep 8, 2015
jszczepkowski added a commit that referenced this pull request Sep 8, 2015
@jszczepkowski
Merge pull request #13640 from socaa/horizontal-pod-autoscaling-test
61a66a9 
Horizontal Pod Autoscaling e2e tests
@jszczepkowski jszczepkowski merged commit 61a66a9 into kubernetes:master Sep 8, 2015
piosz
piosz reviewed Sep 9, 2015
View reviewed changes
test/e2e/autoscaling_utils.go
rc.stop <- 0
expectNoError(DeleteRC(rc.framework.Client, rc.framework.Namespace.Name, rc.name))
expectNoError(rc.framework.Client.Services(rc.framework.Namespace.Name).Delete(rc.name))
expectNoError(rc.framework.Client.Experimental().HorizontalPodAutoscalers(rc.framework.Namespace.Name).Delete(rc.name, api.NewDeleteOptions(0)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@socaa This is a very bad pattern when you clean up here resources created by someone else. Please move this call to test/e2e/horizontal_pod_autoscaling.go

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Horizontal Pod Autoscaler is deleted along with namespace (changes in new PR: #13786 )

@jszczepkowski
Copy link
Contributor

Part of #12087.

@piosz piosz mentioned this pull request Sep 17, 2015
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jszczepkowski jszczepkowski

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@socaa @k8s-github-robot @k8s-bot @jszczepkowski @piosz @googlebot