Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable swap memory on vagrant nodes to support qos properly #13527

Merged
1 commit merged into from
Sep 4, 2015
Merged

Disable swap memory on vagrant nodes to support qos properly #13527

1 commit merged into from
Sep 4, 2015

Conversation

derekwaynecarr
Copy link
Member

I want to be able to use the vagrant cluster to test Kubernetes QoS behaviors with OOM.

The QoS proposal assumes that swap memory is disabled. If swap is enabled, then resource guarantees (for pods that specify resource requirements) will not hold. For example, suppose 2 guaranteed pods have reached their memory limit. They can start allocating memory on swap space. Eventually, if there isn’t enough swap space, processes in the pods might get killed.

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 2, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-bot
Copy link

k8s-bot commented Sep 2, 2015

GCE e2e build/test failed for commit 5b594d7b128ce5ba19bff759bb45c8885f454f28.

@k8s-bot
Copy link

k8s-bot commented Sep 3, 2015

GCE e2e build/test passed for commit 44e74b4.

@derekwaynecarr derekwaynecarr added e2e-not-required lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 4, 2015
@derekwaynecarr
Copy link
Member Author

Self tagging PR since its been a few days with no interaction, and its focused on vagrant which I maintain, and is a simple one-liner.

@ghost ghost self-assigned this Sep 4, 2015
@ghost
Copy link

ghost commented Sep 4, 2015

LGTM. Apologies for the languishment on this one @derekwaynecarr :-)

ghost pushed a commit that referenced this pull request Sep 4, 2015
Merge pull request #13527 from derekwaynecarr/disable_swap
de3cf9b 
Disable swap memory on vagrant nodes to support qos properly
@ghost ghost merged commit de3cf9b into kubernetes:master Sep 4, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derekwaynecarr @k8s-github-robot @k8s-bot @googlebot