Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "kubectl replace" in update-storage-objects.sh #13376

Merged
merged 1 commit into from
Sep 4, 2015
Merged

Use "kubectl replace" in update-storage-objects.sh #13376

merged 1 commit into from
Sep 4, 2015

Conversation

gouyang
Copy link
Contributor

@gouyang gouyang commented Aug 31, 2015

Signed-off-by: Guohua Ouyang gouyang@redhat.com

@gouyang
Use "kubectl replace" in update-storage-objects.sh
4393116 
Signed-off-by: Guohua Ouyang <gouyang@redhat.com>
@k8s-bot
Copy link

k8s-bot commented Aug 31, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@jszczepkowski jszczepkowski added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2015
@jszczepkowski
Copy link
Contributor

LGTM

@lavalamp
Copy link
Member

add to whitelist

@k8s-bot
Copy link

k8s-bot commented Aug 31, 2015

GCE e2e build/test failed for commit 4393116.

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 2, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@jszczepkowski jszczepkowski self-assigned this Sep 2, 2015
@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

3 similar comments
@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@jszczepkowski
Copy link
Contributor

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Sep 3, 2015

GCE e2e build/test failed for commit 4393116.

@ghost
Copy link

ghost commented Sep 3, 2015

e2e test failure was due to #13534. Retrying to trigger auto-merge by merge-bot.
@k8s-bot test this again please

@ghost
Copy link

ghost commented Sep 3, 2015

Note: the e2e test should not be required, modulo bugs in the merge-bot. But lets see what happens.

@k8s-bot
Copy link

k8s-bot commented Sep 4, 2015

GCE e2e build/test passed for commit 4393116.

piosz added a commit that referenced this pull request Sep 4, 2015
@piosz
Merge pull request #13376 from gouyang/fix-upgrade-storage-script
78e7cc8 
Use "kubectl replace" in update-storage-objects.sh
@piosz piosz merged commit 78e7cc8 into kubernetes:master Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jszczepkowski jszczepkowski

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gouyang @k8s-bot @jszczepkowski @lavalamp @k8s-github-robot @googlebot @brendandburns @piosz