Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't name 'eth0' in MASQUERADE rule #13348

Merged
merged 1 commit into from
Sep 2, 2015

Conversation

thockin
Copy link
Member

@thockin thockin commented Aug 29, 2015

This causes endless loops of adding duplicate rules on machines without "eth0".

This causes endless loops of adding duplicate rules on machines without "eth0".
@thockin
Copy link
Member Author

thockin commented Aug 29, 2015

I think this is a better fix for #11810

@thockin
Copy link
Member Author

thockin commented Aug 29, 2015

@bnprss

@k8s-bot
Copy link

k8s-bot commented Aug 29, 2015

GCE e2e build/test passed for commit 1aca401.

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/S

@thockin
Copy link
Member Author

thockin commented Sep 2, 2015

ping @ArtfulCoder

@ArtfulCoder ArtfulCoder added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2015
ArtfulCoder added a commit that referenced this pull request Sep 2, 2015
Don't name 'eth0' in MASQUERADE rule
@ArtfulCoder ArtfulCoder merged commit 067e76b into kubernetes:master Sep 2, 2015
erictune added a commit to erictune/kubernetes that referenced this pull request Oct 5, 2015
Replace "eth0" with "cbr0" in "ip add" command,
as reported by github user @kjvalencik.

Update iptables command to match changes in kubernetes#13348.
@thockin thockin deleted the kubelet-masq-rule branch November 14, 2015 02:48
RichieEscarez pushed a commit to RichieEscarez/kubernetes that referenced this pull request Dec 4, 2015
Replace "eth0" with "cbr0" in "ip add" command,
as reported by github user @kjvalencik.

Update iptables command to match changes in kubernetes#13348.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants