Dynamic cpu consumption #13243

socaa · 2015-08-27T08:10:32Z

Part of #11570

@piosz

k8s-bot · 2015-08-27T08:34:04Z

GCE e2e build/test passed for commit 58c5a694638f810e156c638b2801d26cea68ce87.

k8s-bot · 2015-08-27T08:54:37Z

GCE e2e build/test passed for commit 69f9c6619a334a1e9c4efd32dfeb9b5efcc7cb0e.

mwielgus · 2015-08-27T20:41:35Z

test/e2e/autoscaling_utils.go

+	. "github.com/onsi/ginkgo"
+)
+
+//		ConsumingRC is a tool for testing. It helps create specified usage of CPU or memory (Warnig: memory not supported)


No extra indent.

socaa · 2015-08-28T08:28:30Z

PTAL

@piosz
@mwielgus

k8s-bot · 2015-08-28T08:42:01Z

GCE e2e build/test passed for commit 5bac8bcff6d50fbfbb407a3959742f43a8ae43c4.

mwielgus · 2015-08-28T08:56:05Z

test/e2e/autoscaling_utils.go

+type ConsumingRC struct {
+	name          string
+	milicores     int
+	mutex         *sync.Mutex


Here was a comment but I apparently didn't click on "Send".

Why do we need this mutex at all? If this is only for testing can we have this single-threaded or using classic go synchronization (via channels).

done via channels

socaa · 2015-08-28T14:05:00Z

PTAL

@piosz
@mwielgus

mwielgus · 2015-08-28T14:11:42Z

test/e2e/autoscaling_utils.go

+	rc.channel <- milicores
+}
+
+func (rc *ConsumingRC) consumeCPU() {


can we name this func a bit different - right now there are 2 methods with the same name that do completely different thing.

k8s-bot · 2015-08-28T14:26:42Z

GCE e2e build/test passed for commit 83abdc27eab88ce0ce325e3bbf339348325748fa.

mwielgus · 2015-08-28T14:27:14Z

test/e2e/autoscaling_utils.go

+			if rest != 0 {
+				go rc.sendOneConsumeCPUrequest(rest, consumptionTimeInSeconds)
+			}
+			time.Sleep(sleepTime)


Having sleep here will probably cause problems with setting the number of millicores - the go routine is blocked here. As the rc.channel is unbuffered the sender of the update will have to wait until the sleep ends.

socaa · 2015-08-31T08:46:25Z

PTAL

@piosz
@mwielgus

k8s-github-robot · 2015-09-01T23:55:26Z

Labelling this PR as size/L

k8s-bot · 2015-09-02T07:29:22Z

GCE e2e build/test failed for commit 0eac84970ab371114b522c9f453fb581508e8a4f.

socaa · 2015-09-02T07:49:23Z

PTAL

@piosz
@mwielgus

k8s-bot · 2015-09-02T08:10:14Z

GCE e2e build/test failed for commit de8ca71d0dab7c9655840810ed656bef8b8e7380.

mwielgus · 2015-09-02T09:43:55Z

LGTM, please squash the commits.

socaa · 2015-09-02T09:50:50Z

Done

@mwielgus

k8s-bot · 2015-09-02T10:14:51Z

GCE e2e build/test failed for commit be61507456f9be615a974182de0a1bc6359e00b7.

jszczepkowski · 2015-09-03T07:06:03Z

@k8s-bot test this please

jszczepkowski · 2015-09-03T07:07:41Z

test/e2e/autoscaling_utils.go

+	stop      chan int
+}
+
+// creates new ConsumingRC


Comments are in wrong format, method name should go first:
// NewConsumingRC creates new ConsumingRC.

socaa · 2015-09-03T07:19:54Z

PTAL

@jszczepkowski

jszczepkowski · 2015-09-03T07:30:30Z

LGTM

k8s-bot · 2015-09-03T07:32:09Z

GCE e2e build/test failed for commit be61507456f9be615a974182de0a1bc6359e00b7.

k8s-bot · 2015-09-03T07:43:32Z

GCE e2e build/test passed for commit 4f282ef.

k8s-github-robot · 2015-09-03T21:28:58Z

@k8s-bot test this [testing build queue, sorry for the noise]

k8s-bot · 2015-09-03T21:31:42Z

GCE e2e build/test failed for commit 4f282ef.

ghost · 2015-09-04T00:11:20Z

Jenkins e2e failure looks like a flake. Retrying.
@k8s-bot test this again please

Error response from daemon: invalid registry endpoint https://gcr.io/v0/: unable to ping registry endpoint https://gcr.io/v0/
v2 ping attempt failed with error: Get https://gcr.io/v2/: read tcp 74.125.69.82:443: i/o timeout
 v1 ping attempt failed with error: Get https://gcr.io/v1/_ping: dial tcp 74.125.69.82:443: i/o timeout. If this private registry supports only HTTP or HTTPS with an unknown CA certificate, please add`--insecure-registry gcr.io` to the daemon's arguments. In the case of HTTPS, if you have access to the registry's CA certificate, no need for the flag; simply place the CA certificate at /etc/docker/certs.d/gcr.io/ca.crt
!!! Error in /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/../build/common.sh:734
  'docker pull "${addon_path}"' exited with status 1
Call stack:
  1: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/../build/common.sh:734 kube::release::write_addon_docker_images_for_server(...)
  2: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/../build/common.sh:651 kube::release::package_server_tarballs(...)
  3: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/../build/common.sh:586 kube::release::package_tarballs(...)
  4: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/release.sh:40 main(...)
Exiting with status 1
!!! [0903 14:31:42] unable to pull or write addon image
!!! Error in /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/../build/common.sh:725
  'kube::release::write_addon_docker_images_for_server "${release_stage}/addons"' exited with status 1
Call stack:
  1: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/../build/common.sh:725 kube::release::write_addon_docker_images_for_server(...)
  2: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/../build/common.sh:651 kube::release::package_server_tarballs(...)
  3: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/../build/common.sh:586 kube::release::package_tarballs(...)
  4: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/release.sh:40 main(...)
Exiting with status 1
!!! [0903 14:31:42] previous tarball phase failed
!!! Error in /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/release.sh:588
  'return 1' exited with status 1
Call stack:
  1: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/release.sh:588 main(...)
Exiting with status 1
2015/09/03 14:31:42 Error running build-release: exit status 1
2015/09/03 14:31:42 Error building. Aborting.
exit status 1
Build step 'Execute shell' marked build as failure

k8s-bot · 2015-09-04T00:55:41Z

GCE e2e build/test failed for commit 4f282ef.

piosz · 2015-09-04T07:12:47Z

@k8s-bot test this please

k8s-bot · 2015-09-04T07:40:32Z

GCE e2e build/test passed for commit 4f282ef.

Dynamic cpu consumption

googlebot added the cla: yes label Aug 27, 2015

socaa force-pushed the dynamic-cpu-consumption branch from 58c5a69 to 69f9c66 Compare August 27, 2015 08:28

piosz assigned mwielgus Aug 27, 2015

mwielgus reviewed Aug 27, 2015
View reviewed changes

mwielgus reviewed Aug 28, 2015
View reviewed changes

socaa force-pushed the dynamic-cpu-consumption branch from de8ca71 to be61507 Compare September 2, 2015 09:50

jszczepkowski added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Sep 3, 2015

jszczepkowski reviewed Sep 3, 2015
View reviewed changes

jszczepkowski removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2015

Added autoscaling utils for dynamic consumption of CPU

4f282ef

socaa force-pushed the dynamic-cpu-consumption branch from be61507 to 4f282ef Compare September 3, 2015 07:17

jszczepkowski added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2015

piosz added a commit that referenced this pull request Sep 4, 2015

Merge pull request #13243 from socaa/dynamic-cpu-consumption

e724a52

Dynamic cpu consumption

piosz merged commit e724a52 into kubernetes:master Sep 4, 2015

piosz mentioned this pull request Sep 4, 2015

Implement Resource Consumer #11570

Closed

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dynamic cpu consumption #13243

Dynamic cpu consumption #13243

socaa commented Aug 27, 2015

k8s-bot commented Aug 27, 2015

k8s-bot commented Aug 27, 2015

mwielgus Aug 27, 2015

socaa Aug 28, 2015

socaa commented Aug 28, 2015

k8s-bot commented Aug 28, 2015

mwielgus Aug 28, 2015

socaa Aug 28, 2015

socaa commented Aug 28, 2015

mwielgus Aug 28, 2015

k8s-bot commented Aug 28, 2015

mwielgus Aug 28, 2015

socaa commented Aug 31, 2015

k8s-github-robot commented Sep 1, 2015

k8s-bot commented Sep 2, 2015

socaa commented Sep 2, 2015

k8s-bot commented Sep 2, 2015

mwielgus commented Sep 2, 2015

socaa commented Sep 2, 2015

k8s-bot commented Sep 2, 2015

jszczepkowski commented Sep 3, 2015

jszczepkowski Sep 3, 2015

socaa commented Sep 3, 2015

jszczepkowski commented Sep 3, 2015

k8s-bot commented Sep 3, 2015

k8s-bot commented Sep 3, 2015

k8s-github-robot commented Sep 3, 2015

k8s-bot commented Sep 3, 2015

ghost commented Sep 4, 2015

k8s-bot commented Sep 4, 2015

piosz commented Sep 4, 2015

k8s-bot commented Sep 4, 2015

Dynamic cpu consumption #13243

Dynamic cpu consumption #13243

Conversation

socaa commented Aug 27, 2015

k8s-bot commented Aug 27, 2015

k8s-bot commented Aug 27, 2015

mwielgus Aug 27, 2015

Choose a reason for hiding this comment

socaa Aug 28, 2015

Choose a reason for hiding this comment

socaa commented Aug 28, 2015

k8s-bot commented Aug 28, 2015

mwielgus Aug 28, 2015

Choose a reason for hiding this comment

socaa Aug 28, 2015

Choose a reason for hiding this comment

socaa commented Aug 28, 2015

mwielgus Aug 28, 2015

Choose a reason for hiding this comment

k8s-bot commented Aug 28, 2015

mwielgus Aug 28, 2015

Choose a reason for hiding this comment

socaa commented Aug 31, 2015

k8s-github-robot commented Sep 1, 2015

k8s-bot commented Sep 2, 2015

socaa commented Sep 2, 2015

k8s-bot commented Sep 2, 2015

mwielgus commented Sep 2, 2015

socaa commented Sep 2, 2015

k8s-bot commented Sep 2, 2015

jszczepkowski commented Sep 3, 2015

jszczepkowski Sep 3, 2015

Choose a reason for hiding this comment

socaa commented Sep 3, 2015

jszczepkowski commented Sep 3, 2015

k8s-bot commented Sep 3, 2015

k8s-bot commented Sep 3, 2015

k8s-github-robot commented Sep 3, 2015

k8s-bot commented Sep 3, 2015

ghost commented Sep 4, 2015

k8s-bot commented Sep 4, 2015

piosz commented Sep 4, 2015

k8s-bot commented Sep 4, 2015