Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

I signed it!

I signed it!

CLAs look good, thanks!

/cc @pires @kelseyhightower

@yujuhong this is true. I've advocated in the past to deprecate CoreOS VMware support because no one seems to maintain it. I do, however, maintain an external version with Vagrant (that supports VMware), which supports the variable used.

As per https://coreos.com/os/docs/latest/cloud-config.html#coreos:

The $private_ipv4 and $public_ipv4 substitution variables referenced in other documents are only supported on Amazon EC2, Google Compute Engine, OpenStack, Rackspace, DigitalOcean, and Vagrant.

@xavierbaude check https://github.com/pires/kubernetes-vagrant-coreos-cluster and let me know.

@pires, do you think it's worth adding the comment here?

@yujuhong tbh I think it's worth removing the VMware specific part of the CoreOS documentation, which I'll be doing in a PR in a few moments.

Your are right, maybe it's not the right choice to put comment in master.yml file. But I can write a specific VMware ESXi procedure here : https://github.com/kubernetes/kubernetes/blob/master/docs/getting-started-guides/coreos/coreos_multinode_cluster.md
or write a new complete guideline here : https://github.com/kubernetes/kubernetes/blob/master/docs/getting-started-guides/coreos.md

A lot of people and enterprise use VMware ESXi, for me it's a good opportunity to catch these people ;).

@xavierbaude please do and open a PR for it to get merged. Right now, I'm favoring #13151

I am closing this PR now that we have #13151 and #13207