Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parameters and flags in Annotate command #13131

Merged
merged 1 commit into from
Sep 1, 2015
Merged

Remove unused parameters and flags in Annotate command #13131

merged 1 commit into from
Sep 1, 2015
+7 −53

Conversation

hurf
Copy link
Contributor

@hurf hurf commented Aug 25, 2015

Some params and flags are set but not used, remove them.

@janetkuo when reading the example you gave, found a small issue.

out and printerFlags are added but not used.

@hurf hurf changed the title Remove unused parameters and flags Remove unused parameters and flags in Annotate command Aug 25, 2015
@hurf
Copy link
Contributor Author

hurf commented Aug 25, 2015

Also changed filenames from annotation to annotate to be consistent with other commands.

@k8s-bot
Copy link

k8s-bot commented Aug 25, 2015

GCE e2e build/test passed for commit f5e5be99889d41d63d1eb58ef35557df4d8d7fef.

@k8s-bot
Copy link

k8s-bot commented Aug 25, 2015

GCE e2e build/test passed for commit 3536d24678b94f845ff9b026efd23389e3cc5bff.

@hurf
Copy link
Contributor Author

hurf commented Aug 27, 2015

@janetkuo , can you please take a look at this?

@hurf
Remove unused parameters and flags
961d7f9 
Some params and flags are set but not used, remove them.
@k8s-bot
Copy link

k8s-bot commented Aug 27, 2015

GCE e2e build/test failed for commit 961d7f9.

@hurf
Copy link
Contributor Author

hurf commented Aug 27, 2015

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Aug 27, 2015

GCE e2e build/test failed for commit 961d7f9.

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 27, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/M

@janetkuo
Copy link
Member

@k8s-bot test this please

@janetkuo
Copy link
Member

@hurf LGTM. Thanks!

@k8s-bot
Copy link

k8s-bot commented Aug 28, 2015

GCE e2e build/test passed for commit 961d7f9.

@hurf
Copy link
Contributor Author

hurf commented Aug 31, 2015

@janetkuo - Can you attach the lgtm label if it really looks good to you?

@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2015
@brendandburns
Copy link
Contributor

closing and re-opening to ping shippable

@brendandburns brendandburns reopened this Aug 31, 2015
@k8s-github-robot
Copy link

@k8s-bot test this [testing build queue, sorry for the noise]

@k8s-bot
Copy link

k8s-bot commented Sep 1, 2015

GCE e2e build/test passed for commit 961d7f9.

@k8s-github-robot
Copy link

Automatic merge from SubmitQueue

k8s-github-robot pushed a commit that referenced this pull request Sep 1, 2015
Merge pull request #13131 from hurf/anno_unused
a4d953f 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit a4d953f into kubernetes:master Sep 1, 2015
@hurf hurf deleted the anno_unused branch September 9, 2015 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@janetkuo janetkuo

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hurf @k8s-bot @k8s-github-robot @janetkuo @brendandburns @googlebot