Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add container name in the probe event message #129300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add container name in the probe event message #129300

wants to merge 1 commit into from

Conversation

astraw99
Copy link
Member

@astraw99 astraw99 commented Dec 19, 2024 •
edited
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

When there are multiple containers in a pod, we use kubectl describe po xxx to show the events,
it is not showing the failed container name, so this PR is to add it in the event message, like:

Events:
  Type     Reason     Age                   From               Message
  ----     ------     ----                  ----               -------
  Normal   Scheduled  18m                   default-scheduler  Successfully assigned xxx/xxx-controller-manager-7c8fcd5fff-4fprb to cloud-dev
  Normal   Pulling    20m                   kubelet            Pulling image "xxx/xxx/xxx:v0.0.1"
  Normal   Pulled     20m                   kubelet            Successfully pulled image "xxx/xxx/xxx-controller:v0.0.1"
  Normal   Started    20m                   kubelet            Started container manager
  Normal   Created    20m                   kubelet            Created container manager
  Normal   Created    19m (x4 over 20m)     kubelet            Created container kube-rbac-proxy
  Normal   Started    19m (x4 over 20m)     kubelet            Started container kube-rbac-proxy
  ...
  Warning  Unhealthy  2m58s (x31 over 10m)  kubelet            [Container abc] Readiness probe failed: HTTP probe failed with statuscode: 500

Which issue(s) this PR fixes:

Fixes #129299

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 19, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl area/kubelet sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 19, 2024
@HirazawaUi
Copy link
Contributor

This PR involves changes in two unrelated areas. Could you split it into two separate PRs to make it easier for reviewers from different SIG to review?

@astraw99 astraw99 force-pushed the ftr-add-describe-info branch from ccd021a to 3c67f3f Compare December 20, 2024 05:10
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: astraw99
Once this PR has been reviewed and has the lgtm label, please assign random-liu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@astraw99
Copy link
Member Author

@HirazawaUi Sure, separated with another PR: #129321
PTAL thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander Awaiting requested review from haircommander

@soltysh soltysh Awaiting requested review from soltysh

Assignees
No one assigned
Labels
area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG CLI
Status: Needs Triage
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container name not showed in the probe event message
3 participants
@astraw99 @k8s-ci-robot @HirazawaUi