Change default filestore permissions to 0700 #129214
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tallclair The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/assign @haircommander @marosset |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/lgtm makes sense to me! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9868de823b299d68ffed6214792119b9948230ab
|
|
@ffromani can you think of any risks here? |
|
Are we sure this change isn't visible to cluster admins? If it is, we should changelog it. |
|
Missed a case in my original analysis of this: #129217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Change the default directory permissions used by
pkg/kubelet/util/store/filestore.gofrom0755to0700. This utility is only used for storing Kubelet state, through either checkpoint_manager or usersns_manager, so there don't need to be any other readers.This change is mainly to protect windows kubelets, which perform chmod on the target directory of
MkdirAll, whether or not it's created (kubernetes/pkg/util/filesystem/util_windows.go
Line 102 in ce31c0f
Fixes #128897
Does this PR introduce a user-facing change?
/sig node
/priority important-soon
/milestone v1.33