Remove unused (?) HealthCheck from KubeletClient #12913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GCE e2e build/test passed for commit 33c894a. |
| @@ -52,6 +52,7 @@ func proxyContext(version string) { | |||
| f := NewFramework("proxy") | |||
| prefix := "/api/" + version | |||
|
|
|||
| // Port here has to be kept in sync with default kubelet port. | |||
There was a problem hiding this comment.
you could always format it with the const
https://github.com/kubernetes/kubernetes/blob/master/pkg/master/ports/ports.go#L28
There was a problem hiding this comment.
I don't understand what you mean.
There was a problem hiding this comment.
Kind of a nit/suggestion. What I mean is the next line could be:
It("should proxy logs on node with explicit kubelet port", func() {
nodeProxyTest(f, version, fmt.Sprintf(":%v/logs/", ports.KubeletPort))
})Then no need for the comment and we only have one thing to keep in sync which is the pkg/master/ports constants.
There was a problem hiding this comment.
This will be no longer true and each Kubelet will be able to have different port.
|
LGTM. Thanks for the cleanup! |
yujuhong
added
the
lgtm
saad-ali
added a commit
that referenced
this pull request
Aug 19, 2015
Remove unused (?) HealthCheck from KubeletClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #12912
cc @dchen1107 @yujuhong @wojtek-t