Revert to go1.22 windows filesystem stdlib behavior #129083
Merged
+132
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Dec 4 10:46:57 UTC 2024. |
k8s-ci-robot
added
sig/storage
|
/test |
k8s-ci-robot
added
the
approved
|
@liggitt: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
no idea how green these are at HEAD, but running the azure and windows test jobs I see: /test pull-kubernetes-e2e-capz-azure-disk |
|
/retest |
liggitt
force-pushed
the
go1.23windows
branch
from
a28c920 to
3878a3a
Compare
k8s-ci-robot
added
size/L
|
/priority critical-urgent |
k8s-ci-robot
added
priority/critical-urgent
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 533ae402c99c6f0222cd805eb60b7faf96838656
|
|
lgtm from storage |
|
Thanks, will let release team lift the hold pull-kubernetes-e2e-capz-windows-master just passed It looks like the pull-kubernetes-e2e-capz-azure-{file,disk} jobs either haven't run or haven't passed since September (or ever), so I wouldn't block on those, I guess |
|
/retest |
|
cool, got a green run from pull-kubernetes-e2e-capz-azure-disk as well |
|
@liggitt: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@liggitt I'm waiting on pull-kubernetes-e2e-gce to unhold, or perhaps that doesn't block either? |
|
thanks for digging into this @liggitt and team!! /approve |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Reverts to go 1.22 windows filesystem behavior until use of Stat/Lstat/EvalSymlinks adjusts to go1.23 behavior
Fixes #129080
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/sig storage windows release
/cc @marosset @msau42