Wait for updated keys to be observed #128966
Conversation
k8s-ci-robot
added
release-note-none
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-priority
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| @@ -235,6 +238,36 @@ func TestExternalJWTSigningAndAuth(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func waitForDataTimestamp(t *testing.T, client kubernetes.Interface, minimumDataTimestamp time.Time) { | |||
There was a problem hiding this comment.
output of running this:
go test ./test/integration/serviceaccount -run TestExternalJWTSigningAndAuth/after_periodic_sync -v -count=1 | grep _test.go
external_jwt_signer_test.go:220: waiting for >=1732553885.155639
external_jwt_signer_test.go:260: apiserver_externaljwt_fetch_keys_data_timestamp at 1732553885.000000, waiting until >=1732553885.155639...
external_jwt_signer_test.go:260: apiserver_externaljwt_fetch_keys_data_timestamp at 1732553885.000000, waiting until >=1732553885.155639...
external_jwt_signer_test.go:260: apiserver_externaljwt_fetch_keys_data_timestamp at 1732553885.000000, waiting until >=1732553885.155639...
external_jwt_signer_test.go:260: apiserver_externaljwt_fetch_keys_data_timestamp at 1732553885.000000, waiting until >=1732553885.155639...
external_jwt_signer_test.go:260: apiserver_externaljwt_fetch_keys_data_timestamp at 1732553885.000000, waiting until >=1732553885.155639...
external_jwt_signer_test.go:263: saw 1732553890.000000
There was a problem hiding this comment.
follow-up for 1.33 in #128967 to actually record the data timestamp from the external signer as a float instead of truncating to seconds
|
/skip |
|
/assign @enj @ahmedtd |
|
@liggitt: GitHub didn't allow me to request PR reviews from the following users: HarshalNeelkamal. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@liggitt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
|
I think I get it. This looks significantly more reliable. /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a3225738c77d53e6698371d93b23d5ee4f75e9cd
|
|
/milestone v1.32 |
What type of PR is this?
/kind cleanup
/kind failing-test
/kind flake
What this PR does / why we need it:
Waits for the metric indicating keys have been observed to be incremented.
This matches how external integrations would detect update of keys as well.
Which issue(s) this PR fixes:
Fixes #128871
Does this PR introduce a user-facing change?