Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][FG:InPlacePodVerticalScaling] Fix windows test fail with InPlacePodVerticalScaling #128936

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP][FG:InPlacePodVerticalScaling] Fix windows test fail with InPlacePodVerticalScaling #128936

wants to merge 1 commit into from

Conversation

esotsal
Copy link

@esotsal esotsal commented Nov 22, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Please check discussion here

Which issue(s) this PR fixes:

Attempt to fix #128897

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: esotsal
Once this PR has been reviewed and has the lgtm label, please assign tallclair for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 22, 2024
This was referenced Nov 22, 2024
Open
Open
@esotsal
Copy link
Author

esotsal commented Nov 22, 2024

/cc dims

@k8s-ci-robot k8s-ci-robot requested a review from dims November 22, 2024 13:49
@esotsal
Copy link
Author

esotsal commented Nov 22, 2024

/test pull-kubernetes-node-kubelet-serial-containerd
/test pull-kubernetes-node-kubelet-serial-containerd-alpha-features
/test pull-kubernetes-node-kubelet-serial-containerd-sidecar-containers
/test pull-kubernetes-e2e-ec2
/test pull-kubernetes-e2e-gce-canary
/test pull-kubernetes-e2e-ec2-conformance
/test pull-kubernetes-e2e-capz-windows-master
/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2

@dims
Copy link
Member

dims commented Nov 22, 2024

/sig windows
/assign @marosset @jsturtevant

Let's make sure the SIG windows leads know that this feature is disabled on windows irrespective of the feature flag status. I am not sure what pattern works best (based on their previous experience).

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Nov 22, 2024
@esotsal
Copy link
Author

esotsal commented Nov 22, 2024

Thanks @dims , fyi Drop InPlacePodVerticalScaling support in windows /cc @AnishShah

@tallclair
Copy link
Member

This is the right idea, but we also need to change when and how IsInPlacePodVerticalScalingAllowed is called.

@esotsal esotsal force-pushed the esotsal/fix-windows-inplacepodverticalscaling branch from 4dd7654 to 67f4e92 Compare November 25, 2024 02:30
@esotsal esotsal mentioned this pull request Nov 25, 2024
Open
@esotsal
Copy link
Author

esotsal commented Nov 28, 2024

This is the right idea, but we also need to change when and how IsInPlacePodVerticalScalingAllowed is called.

True, moving here comments from @dims @pohly , @pacoxu , to continue discussion here

#128880 (comment) , #128880 (comment) , #128880 (comment)

@esotsal esotsal changed the title Fix windows fail with InPlacePodVerticalScaling [FG:InPlacePodVerticalScaling] Fix windows fail with InPlacePodVerticalScaling Nov 28, 2024
@esotsal esotsal changed the title [FG:InPlacePodVerticalScaling] Fix windows fail with InPlacePodVerticalScaling [FG:InPlacePodVerticalScaling] Fix windows test fail with InPlacePodVerticalScaling Nov 28, 2024
@esotsal esotsal changed the title [FG:InPlacePodVerticalScaling] Fix windows test fail with InPlacePodVerticalScaling [WIP][FG:InPlacePodVerticalScaling] Fix windows test fail with InPlacePodVerticalScaling Nov 28, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthyx matthyx Awaiting requested review from matthyx

@tallclair tallclair Awaiting requested review from tallclair

@dims dims Awaiting requested review from dims

Assignees

@jsturtevant jsturtevant

@marosset marosset

Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node: In Place Pod Vertical Scaling
Status: In Progress
SIG Node: code and documentation PRs
Status: Work in progress
[sig-windows] PR tracking
Status: No status
Milestone
No milestone
6 participants
@esotsal @k8s-ci-robot @dims @tallclair @jsturtevant @marosset