DRA API: validate node selector labels #128932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ValidateNodeSelector did not check that labels are valid. Now it does for resource.k8s.io, regardless whether an object already was created with invalid labels in an earlier Kubernetes release. Theoretically this is a breaking change and could cause problems during an upgrade, but that is highly unlikely in practice. In contrast to node affinity, DRA does not ignore parse errors (= uses NewNodeSelector, not NewLazyErrorNodeSelector), so invalid labels would have been found instead of being silently ignored. Even if some object has invalid labels, this only affects an alpha -> beta upgrade which isn't guaranteed to work seamlessly.
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
size/L
|
/priority critical-urgent |
k8s-ci-robot
added
priority/critical-urgent
|
change lgtm I'm strongly in favor of tightening the validation prior to the beta API release. @thockin, would you agree? If so, this will need milestoning by the release team, ideally ahead of the rc.0 |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 922547ff7b7cc56898038b29ac3120e9d39941dc
|
k8s-ci-robot
added
the
approved
|
/hold For comment by @thockin, in case that we get the milestone first. |
k8s-ci-robot
added
the
do-not-merge/hold
|
/milestone v1.32 |
fsmunoz
approved these changes
Nov 22, 2024
liggitt
added
the
triage/accepted
k8s-ci-robot
removed
the
needs-triage
|
ACK to fix this before 32. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fsmunoz, liggitt, pohly, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thockin
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Previously, ValidateNodeSelector did not check that labels are valid. Now it does for resource.k8s.io, regardless whether an object already was created with invalid labels in an earlier Kubernetes release. Theoretically this is a breaking change and could cause problems during an upgrade, but that is highly unlikely in practice.
In contrast to node affinity, DRA does not ignore parse errors (= uses NewNodeSelector, not NewLazyErrorNodeSelector), so invalid labels would have been found instead of being silently ignored.
Even if some object has invalid labels, this only affects an alpha -> beta upgrade which isn't guaranteed to work seamlessly.
Which issue(s) this PR fixes:
Related-to: #128156
Special notes for your reviewer:
This PR is a subset of #128212. It was stripped down to just the parts which strengthen validation of resource.k8s.io.
We need to get this included in 1.32 because the resource.k8s.io API gets promoted to beta in 1.32. Making this change later would be more complicated.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @AxeZhan @thockin @liggitt @kubernetes/release-team-leads