Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added calico-kubernetes-fedora-digitalocean demo #12887

Merged
merged 3 commits into from
Sep 18, 2015
Merged

added calico-kubernetes-fedora-digitalocean demo #12887

merged 3 commits into from
Sep 18, 2015

Conversation

ozdanborne
Copy link
Contributor

No description provided.

@k8s-bot
Copy link

k8s-bot commented Aug 18, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@roberthbailey
Copy link
Contributor

@k8s-bot ok to test

@k8s-bot
Copy link

k8s-bot commented Aug 19, 2015

GCE e2e build/test passed for commit 444ff4d.

@ozdanborne
Copy link
Contributor Author

@google-admin Anything I can do to get this merged?

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 27, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/L

@erictune
Copy link
Member

erictune commented Sep 1, 2015

I'm on vacation this week (:house: :mouse:) and will take a look next week.

@erictune
Copy link
Member

lgtm

@erictune erictune added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Sep 14, 2015
@k8s-github-robot
Copy link

Continuous integration appears to have missed, closing and re-opening to trigger it

@erictune
Copy link
Member

@djosborne flags with underscores are deprecated. Can you please update the instructions to use the same flags but with dashes. In particular, in docs/getting-started-guides/fedora/fedora-calico.md:

  • --hostname_override=127.0.0.1 ➡️ --hostname-override=127.0.0.1
  • --api_servers=http://kube-master:8080 ➡️ --api-servers=http://kube-master:8080
  • --admission_control=... ➡️ --admission-control-...
  • --etcd_servers=... ➡️ --etcd-servers=...

@erictune erictune removed lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Sep 15, 2015
Alexander Hersh and others added 2 commits September 15, 2015 10:26
@k8s-bot
Copy link

k8s-bot commented Sep 15, 2015

GCE e2e build/test passed for commit c79d1fd.

@erictune
Copy link
Member

LGTM

@erictune erictune added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-merge and removed needs-ok-to-merge labels Sep 18, 2015
thockin added a commit that referenced this pull request Sep 18, 2015
@thockin
Merge pull request #12887 from djosborne/master
6def707 
added calico-kubernetes-fedora-digitalocean demo
@thockin thockin merged commit 6def707 into kubernetes:master Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erictune erictune

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ozdanborne @k8s-bot @roberthbailey @k8s-github-robot @erictune @googlebot @thockin @djosborne