Vendoring changes for new hnslib v0.0.8. #128841
Conversation
k8s-ci-robot
added
release-note-none
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @princepereira. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-priority
k8s-ci-robot
added
the
area/dependency
princepereira
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/sig architecture instrumentation windows |
k8s-ci-robot
added
sig/architecture
|
update lgtm, unwanted-dependencies.json needs updating to show we dropped stuff we didn't want any more and to lock that in 🎉 "github.com/golang/groupcache": [
- "github.com/Microsoft/hnslib",
- "go.etcd.io/etcd/server/v3",
- "go.opencensus.io"
+ "go.etcd.io/etcd/server/v3"
],
...
- "go.opencensus.io": [
- "github.com/Microsoft/hnslib"
- ],
...
"unwantedVendored": [
"github.com/davecgh/go-spew",
"github.com/gogo/protobuf",
- "github.com/golang/groupcache",
"github.com/google/gofuzz",
"github.com/google/shlex",
...
"github.com/mailru/easyjson",
"github.com/pkg/errors",
- "go.opencensus.io",
"golang.org/x/exp",
"google.golang.org/genproto"
... |
princepereira
force-pushed
the
ppereira-remove-opencensus
branch
from
06c23fc to
07c79da
Compare
|
/test |
|
@liggitt: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-kubernetes-e2e-capz-windows-master Since this update is strictly deleting code / dependencies, and is doing so on a couple of dependencies we know we want to drop and have been problematic in the past (resolves an issue we ran into in #128419), I'd at least consider merging this post-code-freeze ahead of 1.32. I'd like feedback from: /sig windows /sig arch /sig release |
k8s-ci-robot
added
the
sig/release
|
@liggitt: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
-Direct Dependencies: 182
-Transitive Dependencies: 330
-Total Dependencies: 366
+Direct Dependencies: 180
+Transitive Dependencies: 329
+Total Dependencies: 365
Max Depth Of Dependencies: 25 |
|
/assign @marosset @liggitt @katcosgrove |
|
/approve I would love for this to land in 1.32 itself. |
k8s-ci-robot
added
the
approved
|
https://prow.k8s.io/job-history/gs/kubernetes-ci-logs/pr-logs/directory/pull-kubernetes-e2e-capz-windows-master looks like it's already failing for unrelated reasons @marosset @princepereira is there a working presubmit we can trigger on this to exercise windows nodes as a sanity check? |
|
/test pull-kubernetes-e2e-capz-windows-master |
The last failure was due to cluster provisioning issues. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 52912d9b52be9d8122a307368fbb124e8b1a090d
|
|
@princepereira: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/skip |
|
+1 this remove dependencies in a very specific area, seems a big net improvement with low risk |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, princepereira, sourad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you all, adding this to 1.32 (cc Enhancements Lead @tjons ) /milestone v1.32 |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This tag (v0.0.8) of hnslib removes the dependency of hnslib, K8S with go.opencensus.io
Which issue(s) this PR fixes:
Fixes # NA
Special notes for your reviewer:
Does this PR introduce a user-facing change?
more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md
-->
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: