Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build etcd image v3.5.17 #128772

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Build etcd image v3.5.17 #128772

merged 1 commit into from
Dec 19, 2024

Conversation

bzsuni
Copy link
Contributor

@bzsuni bzsuni commented Nov 13, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

etcd is now released in 3.5.17

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

none

@bzsuni
Build etcd image v3.5.17
7e06739 
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 13, 2024
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 13, 2024
@humblec
Copy link
Contributor

humblec commented Nov 14, 2024

why 2 PRs here @bzsuni for the bump (#128773) ?

@bzsuni
Copy link
Contributor Author

bzsuni commented Nov 14, 2024

why 2 PRs here @bzsuni for the bump (#128773) ?

We need to build it first before updating, correct?

@pacoxu pacoxu mentioned this pull request Dec 5, 2024
Closed
@aladesawe
Copy link

@bzsuni @humblec lgtm, comparing to v3.5.16 build. I'm new to the project though, so I may be missing the bigger picture for this upgrade.

@humblec
Copy link
Contributor

humblec commented Dec 18, 2024

/lgtm
cc @ahrtr @serathius

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 53e0740b07b36601bd8f8456cf4efae2b01ba80a

@ahrtr
Copy link
Member

ahrtr commented Dec 18, 2024

/lgtm
/approve

@serathius
Copy link
Contributor

/lgtm
/approve

@bzsuni
Copy link
Contributor Author

bzsuni commented Dec 19, 2024

@liggitt for approval please

@dims
Copy link
Member

dims commented Dec 19, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, bzsuni, dims, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2819f2d into kubernetes:master Dec 19, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Dec 19, 2024
@hakman hakman mentioned this pull request Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@serathius serathius Awaiting requested review from serathius

Assignees

@humblec humblec

@serathius serathius

@ahrtr ahrtr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
7 participants
@bzsuni @k8s-ci-robot @humblec @aladesawe @ahrtr @serathius @dims