Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: split TestCoreResourceEnqueue to deal with the timeout issue #128765

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: split TestCoreResourceEnqueue to deal with the timeout issue #128765

merged 1 commit into from
Nov 14, 2024
+2,367 −2,192

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Nov 12, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

test/integration/scheduler/queueing/queue_test.go hits the timeout sometimes, and we should split some tests to reduce the whole execution time.

This PR moves TestCoreResourceEnqueue, which should take the largest time, out of test/integration/scheduler/queueing/queue_test.go.
And, furthermore, it decides TestCoreResourceEnqueue into the ones with the QHint feature gate enabled, and the ones with disabled.
And we could eventually remove test/integration/scheduler/queueing/former/ once the QHint reaches GA.

Which issue(s) this PR fixes:

Fixes #128688

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 12, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 12, 2024
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 12, 2024
@sanposhiho sanposhiho force-pushed the split-tests branch 2 times, most recently from 8580ab8 to 96c05a6 Compare November 12, 2024 17:09
@sanposhiho
Copy link
Member Author

/cc @macsko @alculquicondor @aojea

@sanposhiho
Copy link
Member Author

/kind flake
/remove-kind feature

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Nov 12, 2024
@sanposhiho sanposhiho force-pushed the split-tests branch 2 times, most recently from 5c76b80 to 21b8cde Compare November 12, 2024 20:45
@sanposhiho
Copy link
Member Author

/retest

@sanposhiho
Copy link
Member Author

@alculquicondor @aojea @pacoxu if we consider it should be included in v1.32, can anyone put the milestone to get it in?
(I'm not sure about the criteria of what is ok now and what is not, given the test freeze is over)

@sanposhiho sanposhiho requested a review from macsko November 13, 2024 08:54
@sanposhiho sanposhiho requested a review from macsko November 13, 2024 08:56
@macsko
Copy link
Member

macsko commented Nov 13, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b6af4c89c9cb7cc9587f6a767f215ffee34cc2ba

alculquicondor
alculquicondor reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
just a couple of nits

test/integration/scheduler/queueing/queue_test.go Outdated Show resolved Hide resolved
test/integration/scheduler/queueing/queueinghint/queue_test.go Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2024
@alculquicondor
Copy link
Member

/milestone v1.32

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Nov 13, 2024
@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 00783021da94b0ae0a2448eff0fd750bf2d631f1

@k8s-ci-robot k8s-ci-robot merged commit 475ee33 into kubernetes:master Nov 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi Awaiting requested review from damemi

@aojea aojea Awaiting requested review from aojea

@macsko macsko Awaiting requested review from macsko

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@alculquicondor alculquicondor

@macsko macsko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.

[Flaking Test] TestRequeueByBindFailure in ci-kubernetes-integration-master
4 participants
@sanposhiho @k8s-ci-robot @macsko @alculquicondor