Revert PR #126533 and add a test case for broken case #128761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere is yaml structed texts in the description. We should find a way to both relign line breaks and not break these kind of texts. Signed-off-by: ah8ad3 <ah8ad3@gmail.com>
k8s-ci-robot
added
release-note-none
|
Seems unrelated |
|
/cc @soltysh |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: cd0345173169479c4f458197caaeac6a9e4747a1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ah8ad3, ardaguclu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/milestone v1.32 |
|
@ah8ad3 Thanks for this PR and for adding CAPI example as unit test, really appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #126533 and add a test case for broken case that mentioned in the #126533 (comment). Which is a part of https://github.com/kubernetes-sigs/cluster-api/blob/f495466327aa340ad8c36182eb4e2797e7e35bef/config/crd/bases/cluster.x-k8s.io_machinedrainrules.yaml#L89
What type of PR is this?
/kind bug
What this PR does / why we need it:
Revert a broken change in
kubectl explainWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?