Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FG:InPlacePodVerticalScaling] Disallow removing requests & limits for Burstable pods. #128683

Merged
merged 1 commit into from
Nov 8, 2024
Merged

[FG:InPlacePodVerticalScaling] Disallow removing requests & limits for Burstable pods. #128683

merged 1 commit into from
Nov 8, 2024
+200 −13

Conversation

AnishShah
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

We decided to remove support for removing requests and limits during a resize. We will revisit this in a future release

Which issue(s) this PR fixes:

Fixes #128677

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed support for removing requests and limits during a pod resize.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1287-in-place-update-pod-resources

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 7, 2024
@AnishShah
Copy link
Contributor Author

/sig node
/triage accepted
/assign @tallclair

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on. area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2024
@AnishShah
Copy link
Contributor Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 7, 2024
@AnishShah
Copy link
Contributor Author

/test pull-kubernetes-node-kubelet-serial-podresize

@tallclair
Copy link
Member

/priority important-soon
/milestone v1.32

/cc @dchen1107

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Nov 7, 2024
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 7, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2024
@thockin
Copy link
Member

thockin commented Nov 8, 2024

/approve still

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AnishShah, dchen1107, tallclair, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
@AnishShah
Copy link
Contributor Author

/test pull-kubernetes-node-kubelet-serial-podresize

@tallclair
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1aaf27ec2ea18273986b56075f556f9c81e35d35

@wendy-ha18
Copy link
Member

wendy-ha18 commented Nov 8, 2024 •
edited
Loading

Hi everyone
Appreciate all of your efforts with this PR!!
A gentle reminder that the code freeze has started 02:00 UTC Friday November 8th 2024 . Please make sure this has both lgtm and approved labels ASAP, and file an Exception.

Thanks everyone!!

@AnishShah
Copy link
Contributor Author

/retest-required

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2024
@AnishShah
Copy link
Contributor Author

/test pull-kubernetes-node-kubelet-serial-podresize

@k8s-ci-robot
Copy link
Contributor

@AnishShah: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-kubelet-serial-podresize 7680f0f link false /test pull-kubernetes-node-kubelet-serial-podresize

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tallclair
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ea97efe923a56cde28a0b65db1eb6c8d4581cd34

@tallclair
Copy link
Member

See #128694 for failing resize tests

@AnishShah
Copy link
Contributor Author

The e2e tests added in this PR passed.

@k8s-ci-robot k8s-ci-robot merged commit 2691a29 into kubernetes:master Nov 8, 2024
15 of 16 checks passed
@AnishShah AnishShah deleted the validation branch November 8, 2024 15:14
@hshiina hshiina mentioned this pull request Nov 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@haircommander haircommander Awaiting requested review from haircommander

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@tallclair tallclair Awaiting requested review from tallclair

@thockin thockin Awaiting requested review from thockin

Assignees

@thockin thockin

@dchen1107 dchen1107

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
SIG Node CI/Test Board
Status: Done
SIG Node: In Place Pod Vertical Scaling
Status: Done
SIG Node: code and documentation PRs
Status: Done
[sig-release] Bug Triage
Archived in project
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.

[FG:InPlacePodVerticalScaling] Disallow removing requsets & limits during resize
6 participants
@AnishShah @tallclair @k8s-ci-robot @dchen1107 @thockin @wendy-ha18