Fix pod scale down failure in EventHandlingPodUpdate scheduler_perf test #128666
Conversation
k8s-ci-robot
added
release-note-none
|
/cc @sanposhiho @pohly |
k8s-ci-robot
added
the
needs-triage
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-priority
k8s-ci-robot
added
area/test
sig/testing
|
/cc @dom4ha |
|
/test pull-kubernetes-scheduler-perf |
| @@ -49,6 +49,10 @@ type updateAny struct { | |||
| UpdatePerSecond int | |||
| // Internal field of the struct used for caching the mapping. | |||
| cachedMapping *meta.RESTMapping | |||
| // List of subresources to update. | |||
There was a problem hiding this comment.
Can you refer to this KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1287-in-place-update-pod-resources
The semantic of the "subresources" is far from being straightforward
There was a problem hiding this comment.
I don't want to refer to specific KEP in the comment when subresources are generic and could be used also in the other scenarios. The KEP just added a subresource (like API sub-endpoint), which can be precisely used to resize the pod, compared to traditional pod update API that can update the other fields.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c26e8c5803f17326e2597bf1f18fb4acb1c8b16e
|
There was a problem hiding this comment.
/approve
/lgtm
/hold
I saw @dom4ha 's comment. Feel free to /unhold.
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: macsko, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
|
@alculquicondor @pohly I think it could be labeled as 1.32 and merged to fix the failing test issue. PTAL |
|
/milestone v1.32 |
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
Changes around InPlacePodVerticalScaling feature (#128266) caused the EventHandlingPodUpdate to fail constantly in
ci-benchmark-scheduler-perf-masterperiodic job. Now, scaling down is not possible through Pod/Update like before, but needs to have a subresource set toresize. This PR adds a possibility to set subresource in updateAny op as well as fixes the issue with test.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: