Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #127834: fix(leaderelection): nil check in OnStoppedLeading func #128340

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Automated cherry pick of #127834: fix(leaderelection): nil check in OnStoppedLeading func #128340

merged 1 commit into from
Nov 12, 2024

Conversation

googs1025
Copy link
Member

Cherry pick of #127834 on release-1.31.

#127834: fix(leaderelection): nil check in OnStoppedLeading func

For details on the cherry pick process, see the cherry pick requests page.

None

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Oct 25, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 25, 2024
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 25, 2024
@googs1025
Copy link
Member Author

/assign @Jefftree @aojea @liggitt

@googs1025
Copy link
Member Author

/kind flake

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 25, 2024
@Jefftree
Copy link
Member

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1893ddf7697bd599b5db271316915802ea458de1

@googs1025
Copy link
Member Author

/retest

@googs1025
Copy link
Member Author

/test pull-kubernetes-unit-go-compatibility

@googs1025
Copy link
Member Author

friendly ping @aojea @liggitt :)

@aojea
Copy link
Member

aojea commented Oct 29, 2024

/lgtm
/approve

qualifies as

Test-only changes to stabilize failing / flaky tests on release branches

@aojea
Copy link
Member

aojea commented Oct 29, 2024

/assign @jpbetz
you have approval permissions here

jpbetz
jpbetz reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 29, 2024
@Jefftree
Copy link
Member

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team October 29, 2024 20:27
@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, googs1025, jpbetz, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 11d2b4d into kubernetes:release-1.31 Nov 12, 2024
16 checks passed
This was referenced Nov 24, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@mwielgus mwielgus Awaiting requested review from mwielgus

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@jpbetz jpbetz

@liggitt liggitt

@aojea aojea

@Jefftree Jefftree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
8 participants
@googs1025 @Jefftree @k8s-ci-robot @aojea @fedebongio @jpbetz @saschagrunert @liggitt