Make nodePort optional in v1 API #12831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GCE e2e build/test passed for commit 75941af. |
|
The current swagger spec is inconsistent with our validation code. One of them must be considered wrong. LGTM |
bgrant0607
added
the
lgtm
roberthbailey
added a commit
that referenced
this pull request
Aug 17, 2015
Make nodePort optional in v1 API
|
Ref #12774 |
|
Also ref #8901 |
|
Now can I change it to be a pointer, so it does not get emitted when 0 ? On Mon, Aug 17, 2015 at 4:28 PM, Brian Grant notifications@github.com
|
|
We don't guarantee stability of the Go structs, but would need to think about compatibility between new client and old server, and vice versa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bgrant0607 Is this change kosher? It's low risk, but not STRICTLY compatible...